Groups > linux.kernel > #1421957

Re: [PATCH 4/5] nvmet-rdma: add a NVMe over Fabrics RDMA target driver

From	Christoph Hellwig <hch@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/5] nvmet-rdma: add a NVMe over Fabrics RDMA target driver
Date	2016-06-14 16:40 +0200
Message-ID	<rJXFw-62a-15@gated-at.bofh.it> (permalink)
References	<rHafU-1OH-31@gated-at.bofh.it> <rHafU-1OH-37@gated-at.bofh.it> <rHnZv-2wN-5@gated-at.bofh.it> <rIhfj-4J5-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jun 09, 2016 at 06:03:51PM -0500, Steve Wise wrote:
> The above nvmet cm event handler, nvmet_rdma_cm_handler(), calls
> nvmet_rdma_queue_connect() for CONNECT_REQUEST events, which calls
> nvmet_rdma_alloc_queue (), which, if it encounters a failure (like creating
> the qp), calls nvmet_rdma_cm_reject () which calls rdma_reject().  The
> non-zero error, however, gets returned back here and this function returns
> the error to the RDMA_CM which will also reject the connection as well as
> destroy the cm_id.  So there are two rejects happening, I think.  Either
> nvmet should reject and destroy the cm_id, or it should do neither and
> return non-zero to the RDMA_CM to reject/destroy.

Can you just send a patch?

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 4/5] nvmet-rdma: add a NVMe over Fabrics RDMA target  driver Christoph Hellwig <hch@infradead.org> - 2016-06-14 16:40 +0200
  RE: [PATCH 4/5] nvmet-rdma: add a NVMe over Fabrics RDMA target driver "Steve Wise" <swise@opengridcomputing.com> - 2016-06-14 17:20 +0200
  RE: [PATCH 4/5] nvmet-rdma: add a NVMe over Fabrics RDMA target driver "Steve Wise" <swise@opengridcomputing.com> - 2016-06-14 17:30 +0200

csiph-web