Groups > linux.kernel > #1421958

Re: [PATCH 1/6] MIPS: BMIPS: add missing console to bcm96358nb4ser

From	Jonas Gorski <jogo@openwrt.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/6] MIPS: BMIPS: add missing console to bcm96358nb4ser
Date	2016-06-14 16:40 +0200
Message-ID	<rJXFw-62a-13@gated-at.bofh.it> (permalink)
References	<rJuDv-38Q-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Álvaro,

On 13 June 2016 at 09:38, Álvaro Fernández Rojas <noltari@gmail.com> wrote:
> Console definition is needed in order to avoid a warning in earlycon to
> console transition.
>
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
> ---
>  arch/mips/boot/dts/brcm/bcm96358nb4ser.dts | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/mips/boot/dts/brcm/bcm96358nb4ser.dts b/arch/mips/boot/dts/brcm/bcm96358nb4ser.dts
> index f412117..702eae2 100644
> --- a/arch/mips/boot/dts/brcm/bcm96358nb4ser.dts
> +++ b/arch/mips/boot/dts/brcm/bcm96358nb4ser.dts

Unfortunately I haven't seen this earlier, but please don't name the
dts file bcm9* unless it's an actual reference/eval board from
Broadcom.

A more sensible name would be neufbox4-sercom.dts or
bcm6358-neufbox4-sercom.dts.


Regards
Jonas

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/6] MIPS: BMIPS: add missing console to bcm96358nb4ser Álvaro Fernández Rojas   <noltari@gmail.com> - 2016-06-13 09:40 +0200
  [PATCH 5/6] MIPS: BMIPS: Add BCM6362 support Álvaro Fernández Rojas   <noltari@gmail.com> - 2016-06-13 09:40 +0200
    Re: [PATCH 5/6] MIPS: BMIPS: Add BCM6362 support Rob Herring <robh@kernel.org> - 2016-06-15 00:40 +0200
  [PATCH 2/6] MIPS: BMIPS: Add device tree example for BCM63268 Álvaro Fernández Rojas   <noltari@gmail.com> - 2016-06-13 09:50 +0200
  Re: [PATCH 1/6] MIPS: BMIPS: add missing console to bcm96358nb4ser Jonas Gorski <jogo@openwrt.org> - 2016-06-14 16:40 +0200

csiph-web