Groups > linux.kernel > #1422015

RE: [PATCH 4/5] nvmet-rdma: add a NVMe over Fabrics RDMA target driver

From	"Steve Wise" <swise@opengridcomputing.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH 4/5] nvmet-rdma: add a NVMe over Fabrics RDMA target driver
Date	2016-06-14 17:30 +0200
Message-ID	<rJYrT-6Cf-29@gated-at.bofh.it> (permalink)
References	(1 earlier) <rHafU-1OH-37@gated-at.bofh.it> <rHnZv-2wN-5@gated-at.bofh.it> <rIhfj-4J5-7@gated-at.bofh.it> <rJXFw-62a-15@gated-at.bofh.it> <rJYrT-6Cf-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> Either
> > > nvmet should reject and destroy the cm_id, or it should do neither and
> > > return non-zero to the RDMA_CM to reject/destroy.
> >
> > Can you just send a patch?
> 
> Yes, I'll send it out in a separate email.

Before I do, what do you think of this (untested)?

diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c
index b1c6e5b..6f0c335 100644
--- a/drivers/nvme/target/rdma.c
+++ b/drivers/nvme/target/rdma.c
@@ -1255,7 +1255,8 @@ static int nvmet_rdma_cm_handler(struct rdma_cm_id *cm_id,

        switch (event->event) {
        case RDMA_CM_EVENT_CONNECT_REQUEST:
-               ret = nvmet_rdma_queue_connect(cm_id, event);
+               if (nvmet_rdma_queue_connect(cm_id, event))
+                       rdma_destroy_id(cm_id);
                break;
        case RDMA_CM_EVENT_ESTABLISHED:
                nvmet_rdma_queue_established(queue);

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 4/5] nvmet-rdma: add a NVMe over Fabrics RDMA target  driver Christoph Hellwig <hch@infradead.org> - 2016-06-14 16:40 +0200
  RE: [PATCH 4/5] nvmet-rdma: add a NVMe over Fabrics RDMA target driver "Steve Wise" <swise@opengridcomputing.com> - 2016-06-14 17:20 +0200
  RE: [PATCH 4/5] nvmet-rdma: add a NVMe over Fabrics RDMA target driver "Steve Wise" <swise@opengridcomputing.com> - 2016-06-14 17:30 +0200

csiph-web