Groups > linux.kernel > #1420871

Re: [PATCH 5/6] x86/ptrace: down with test_thread_flag(TIF_IA32)

Path	csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!news2.arglkargh.de!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Oleg Nesterov <oleg@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 5/6] x86/ptrace: down with test_thread_flag(TIF_IA32)
Date	Mon, 13 Jun 2016 16:00:07 +0200
Message-ID	<rJAzl-72E-29@gated-at.bofh.it> (permalink)
References	<rFedX-qG-13@gated-at.bofh.it> <rFedY-qG-49@gated-at.bofh.it> <rHbbY-2wa-5@gated-at.bofh.it> <rIbWi-10d-41@gated-at.bofh.it> <rIAUG-16H-7@gated-at.bofh.it> <rIB4m-1c8-15@gated-at.bofh.it>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.24 (2015-08-30)
X-Scanned-By	MIMEDefang 2.68 on 10.5.11.27
X-Greylist	Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Mon, 13 Jun 2016 13:50:30 +0000 (UTC)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	46
Organization	linux.* mail to news gateway
X-Original-Cc	Dmitry Safonov <dsafonov@virtuozzo.com>, "H. Peter Anvin" <hpa@zytor.com>, Dmitry Safonov <0x7f454c46@gmail.com>, khorenko@virtuozzo.com, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Thomas Gleixner <tglx@linutronix.de>, Cyrill Gorcunov <gorcunov@openvz.org>, xemul@virtuozzo.com, X86 ML <x86@kernel.org>, Ingo Molnar <mingo@redhat.com>
X-Original-Date	Mon, 13 Jun 2016 15:50:20 +0200
X-Original-Message-ID	<20160613135020.GA27007@redhat.com>
X-Original-References	<1464786697-20639-1-git-send-email-dsafonov@virtuozzo.com> <1464786697-20639-6-git-send-email-dsafonov@virtuozzo.com> <20160606211918.GB23681@redhat.com> <CALCETrWD8cvyNqW_2rxSDd2A345nOv47t+i2JhrCU2V7TpPNBQ@mail.gmail.com> <20160610200739.GA14789@redhat.com> <CALCETrWM1xr_5jkxofdW+iEoTmZpaOFDOBroaaB=UMM1pYct3A@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1420871

Show key headers only | View raw

To avoid the confusion, let me first say that I am not going to argue
with these changes, I simply do not understand the problem space enough.

On 06/10, Andy Lutomirski wrote:
>
> On Fri, Jun 10, 2016 at 1:07 PM, Oleg Nesterov <oleg@redhat.com> wrote:
> >
> > IIRC, CRIU can't c/r the 32-bit applications, or this is no longer true?
> >
>
> CRIU has a horrible, nasty, brilliant idea: it will start restoring
> 32-bit processes by treating them mostly like 64-bit processes.  The
> restorer will start out 64-bit, set everything up, and long
> jump/return/sigreturn/whatever back to 32-bit mode.

OK, I see,

> My proposal was
> that, rather than coming up with nasty hacks to switch the kernel's
> idea of the task bitness,

Well, I can't resist but to me SA_IA32_ABI/SA_X32_ABI looks like a hack
too.  We actually shift TIF_*32 into k_sigaction->flags, and the fact
that we do this per-signal looks, well, interesting ;)

And at first glance it would be very simple to change the task bitness,
CRIU can simply exec a dummy 32-bit application before anything else.
In this case (I think) we also do not need do_map_vdso/ARCH_MAP_VDSO_*
at least right now.

Yes, I guess this will complicate CRIU significantly.

> we instead teach the kernel to respect that
> actual bitness as indicated by CS and the syscalls used to the extent
> possible.

I am still not sure the idea to remove TIF_IA32/TIF_X32 is really good.
But again, I won't argue, I do not feel I understand pro/cons enough.

> So, yes, a restored 32-bit process that crashes should dump core as
> though it's 32-bit even though it was 64-bit when execve was last
> called :)

OK, thanks for you explanation Andy.

Oleg.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 5/6] x86/ptrace: down with test_thread_flag(TIF_IA32) Oleg Nesterov <oleg@redhat.com> - 2016-06-13 16:00 +0200
  Re: [PATCH 5/6] x86/ptrace: down with test_thread_flag(TIF_IA32) Andy Lutomirski <luto@amacapital.net> - 2016-06-13 22:50 +0200
    Re: [PATCH 5/6] x86/ptrace: down with test_thread_flag(TIF_IA32) Oleg Nesterov <oleg@redhat.com> - 2016-06-14 16:40 +0200

csiph-web