Groups > linux.kernel > #1421960

Re: [PATCH 5/6] x86/ptrace: down with test_thread_flag(TIF_IA32)

From	Oleg Nesterov <oleg@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 5/6] x86/ptrace: down with test_thread_flag(TIF_IA32)
Date	2016-06-14 16:40 +0200
Message-ID	<rJXFw-62a-27@gated-at.bofh.it> (permalink)
References	(3 earlier) <rIbWi-10d-41@gated-at.bofh.it> <rIAUG-16H-7@gated-at.bofh.it> <rIB4m-1c8-15@gated-at.bofh.it> <rJAzl-72E-29@gated-at.bofh.it> <rJGY1-2UX-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 06/13, Andy Lutomirski wrote:
>
> On Mon, Jun 13, 2016 at 6:50 AM, Oleg Nesterov <oleg@redhat.com> wrote:
> >
> > Well, I can't resist but to me SA_IA32_ABI/SA_X32_ABI looks like a hack
> > too.  We actually shift TIF_*32 into k_sigaction->flags, and the fact
> > that we do this per-signal looks, well, interesting ;)
>
> Is anything actually wrong with this, though?

No, I think the patch is correct... It adds the user-visible change, but
I do not think it can break something.

Well, perhaps we should also remove SA_IA32_ABI|SA_X32_ABI from
oact->sa.sa_flags in do_sigaction() to ensure that these non-uapi flags won't
leak to user-space, but probably we do not really care.

Oleg.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 5/6] x86/ptrace: down with test_thread_flag(TIF_IA32) Oleg Nesterov <oleg@redhat.com> - 2016-06-13 16:00 +0200
  Re: [PATCH 5/6] x86/ptrace: down with test_thread_flag(TIF_IA32) Andy Lutomirski <luto@amacapital.net> - 2016-06-13 22:50 +0200
    Re: [PATCH 5/6] x86/ptrace: down with test_thread_flag(TIF_IA32) Oleg Nesterov <oleg@redhat.com> - 2016-06-14 16:40 +0200

csiph-web