Groups > linux.kernel > #1420872

Re: [PATCH 0/3] mm, thp: remove duplication and fix locking issues in swapin

From	Michal Hocko <mhocko@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/3] mm, thp: remove duplication and fix locking issues in swapin
Date	2016-06-13 16:00 +0200
Message-ID	<rJAzl-72E-19@gated-at.bofh.it> (permalink)
References	<rC1Gh-gw-3@gated-at.bofh.it> <rC1PX-k3-3@gated-at.bofh.it> <rDpQd-3Uj-9@gated-at.bofh.it> <rIWLw-75i-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat 11-06-16 22:21:06, Ebru Akagunduz wrote:
> On Fri, May 27, 2016 at 03:12:47PM +0200, Michal Hocko wrote:
[...]
> > IMHO we should drop the current ALLOCSTALL heuristic and replace it with
> > ~__GFP_DIRECT_RECLAIM.
>
> Actually, I don't lean towards to touch do_swap_page giving gfp parameter.
> do_swap_page is also used by do_page_fault, it can cause many side effect
> that I can't see. 

The point of the patch is to keep the current gfp mask from all places
except for the optimistic swapin. This was what my example patch did
AFAIR.
 
> I've just sent a patch series for converting from optimistic to
> conservative and take back allocstall. Maybe that way can be easier to
> be approved and less problemitical.

I will try to have a look but I will be travelling this week so cannot
promise anything.
-- 
Michal Hocko
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 0/3] mm, thp: remove duplication and fix locking issues  in swapin Ebru Akagunduz <ebru.akagunduz@gmail.com> - 2016-06-11 21:30 +0200
  Re: [PATCH 0/3] mm, thp: remove duplication and fix locking issues  in swapin Michal Hocko <mhocko@kernel.org> - 2016-06-13 16:00 +0200

csiph-web