Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1415946
| Path | csiph.com!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | David Binderman <linuxdev.baldrick@gmail.com> |
| Newsgroups | linux.kernel |
| Subject | linux-4.7-rc2/drivers/net/ethernet/freescale/fman/fman.c:2329]: (style) Redundant condition |
| Date | Tue, 07 Jun 2016 11:50:02 +0200 |
| Message-ID | <rHlO2-109-17@gated-at.bofh.it> (permalink) |
| X-Original-To | netdev@vger.kernel.org, linux-kernel@vger.kernel.org, dcb314@hotmail.com |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to; bh=iUHbJ1lqjzYwTwiEUmhyQLf/2w1x2UU19bYwEztLEdU=; b=lntdNs7gWaHWVpxQ2/85FHQZzj5WUN0WpuO9NyKDkPRwvQuf3YEUg6HhFTwdVt2JtL Tc9Lpwe5FcmYXgy+1dEPNng4rl0NCRmPATM29pSv/fpEiqgs7UqAAQfhSTqqtCCVYCSn DXwKnXKWNG3HWnYFGMkhhuZ+9ZdcxsWt7hYYvh1kiAbTKwRMJTP1PYQARuROLhc2OTgB ek8LXnlCVrdGWhPvrjoPdix+CxqBgA3fFd4kw8oxQJZbVt8xk6N9mCWQBh6MhAapu/dR /gvOEN+yyC9EppuJGLc//IwZpJ9EyJQyK6rAUudbB5vNtkSwesC2Ir2xVruO9bGH1FWJ D1bA== |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=iUHbJ1lqjzYwTwiEUmhyQLf/2w1x2UU19bYwEztLEdU=; b=hPD72sGWi6BItVcbbCyI9P5STRSK0Ri05rDvqDt1bsxvX5wSIO9WoNVU/fiYEbbeqO kQ5pQv57s8hPe7LdYBi+5LIGbU4ZwmNn6ziLwihQUtlwVEEjA1KjDBaCbGI2Xh8Pdyho vj7xQzuBbKBbbMnvGEhngvvO9FY2mVmvfL8dhM0vdN/MshA7otB4SzjEi1N4rXYI0K16 Ai9appOY7dr18GIvh0051HaaD5JFjXTTZ0Tq7jF5PWqBDue+QZwMi4F8jPNJIUwm1IcV WHs1dHp0jLYyxJTsYBPkhxG5/2nZBOjM7wFlUzjdA1MTTaH0p8HDqRcT842H1Bken6W+ xYkA== |
| X-Gm-Message-State | ALyK8tJIuFH9UT1q5pvTuYusXqB19pUxjJ0f74w0Zw1Jvs7UpxzQ+bQdR6Y3xu3w7rl3VnIba9rY6V5bOcsY1w== |
| X-Received | by 10.36.184.130 with SMTP id m124mr2221253ite.95.1465292469417; Tue, 07 Jun 2016 02:41:09 -0700 (PDT) |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=UTF-8 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 20 |
| Organization | linux.* mail to news gateway |
| X-Original-Date | Tue, 7 Jun 2016 10:41:09 +0100 |
| X-Original-Message-ID | <CAMzoamZfyCrPFWVr-nh3HvG6v7UXT_SWCfxF0pTjNeOuX4w7uA@mail.gmail.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1415946 |
Show key headers only | View raw
Hello there,
linux-4.7-rc2/drivers/net/ethernet/freescale/fman/fman.c:2329]:
(style) Redundant condition: fman.state.port_mfl[mac_id]. '!A || (A &&
B)' is equivalent to '!A || B'
Source code is
if ((!fman->state->port_mfl[mac_id]) ||
(fman->state->port_mfl[mac_id] &&
(mfl <= fman->state->port_mfl[mac_id]))) {
Suggest new code
if ((!fman->state->port_mfl[mac_id]) ||
(mfl <= fman->state->port_mfl[mac_id])) {
Regards
David Binderman
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
linux-4.7-rc2/drivers/net/ethernet/freescale/fman/fman.c:2329]: (style) Redundant condition David Binderman <linuxdev.baldrick@gmail.com> - 2016-06-07 11:50 +0200
csiph-web