Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1415946

linux-4.7-rc2/drivers/net/ethernet/freescale/fman/fman.c:2329]: (style) Redundant condition

From David Binderman <linuxdev.baldrick@gmail.com>
Newsgroups linux.kernel
Subject linux-4.7-rc2/drivers/net/ethernet/freescale/fman/fman.c:2329]: (style) Redundant condition
Date 2016-06-07 11:50 +0200
Message-ID <rHlO2-109-17@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw

Hello there,

linux-4.7-rc2/drivers/net/ethernet/freescale/fman/fman.c:2329]:
(style) Redundant condition: fman.state.port_mfl[mac_id]. '!A || (A &&
B)' is equivalent to '!A || B'

Source code is

    if ((!fman->state->port_mfl[mac_id]) ||
        (fman->state->port_mfl[mac_id] &&
        (mfl <= fman->state->port_mfl[mac_id]))) {

Suggest new code

    if ((!fman->state->port_mfl[mac_id]) ||
        (mfl <= fman->state->port_mfl[mac_id])) {

Regards

David Binderman

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

linux-4.7-rc2/drivers/net/ethernet/freescale/fman/fman.c:2329]:  (style) Redundant condition David Binderman <linuxdev.baldrick@gmail.com> - 2016-06-07 11:50 +0200

csiph-web