Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1415946 > unrolled thread

linux-4.7-rc2/drivers/net/ethernet/freescale/fman/fman.c:2329]: (style) Redundant condition

Back to article view | Back to linux.kernel

Contents

  linux-4.7-rc2/drivers/net/ethernet/freescale/fman/fman.c:2329]:  (style) Redundant condition David Binderman <linuxdev.baldrick@gmail.com> - 2016-06-07 11:50 +0200

#1415946 — linux-4.7-rc2/drivers/net/ethernet/freescale/fman/fman.c:2329]: (style) Redundant condition

Hello there,

linux-4.7-rc2/drivers/net/ethernet/freescale/fman/fman.c:2329]:
(style) Redundant condition: fman.state.port_mfl[mac_id]. '!A || (A &&
B)' is equivalent to '!A || B'

Source code is

    if ((!fman->state->port_mfl[mac_id]) ||
        (fman->state->port_mfl[mac_id] &&
        (mfl <= fman->state->port_mfl[mac_id]))) {

Suggest new code

    if ((!fman->state->port_mfl[mac_id]) ||
        (mfl <= fman->state->port_mfl[mac_id])) {

Regards

David Binderman

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web