Re: Regression in "kbuild: fix if_change and friends to consider argument order"

From	"Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
Newsgroups	linux.kernel
Subject	Re: Regression in "kbuild: fix if_change and friends to consider argument order"
Date	2016-06-09 01:30 +0200
Message-ID	<rHV57-6GU-5@gated-at.bofh.it> (permalink)
References	(3 earlier) <rHm7n-1lU-7@gated-at.bofh.it> <rHmK6-1z7-27@gated-at.bofh.it> <rHnwu-25S-23@gated-at.bofh.it> <rHq1j-3KB-9@gated-at.bofh.it> <rHxcu-85W-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Em Ter, 2016-06-07 às 23:52 +0200, Michal Marek escreveu:
> On Tue, Jun 07, 2016 at 02:10:28PM +0000, Zanoni, Paulo R wrote:
> > 
> 
> From b36fad65d61fffe4b662d4bfb1ed673c455a36a2 Mon Sep 17 00:00:00
> 2001
> From: Michal Marek <mmarek@suse.com>
> Date: Tue, 7 Jun 2016 11:57:02 +0200
> Subject: [PATCH] kbuild: Initialize exported variables
> 
> The NOSTDINC_FLAGS variable is exported, so it needs to be cleared to
> avoid duplicating its content when running make from within make
> (e.g.
> in the packaging targets). This became an issue after commit
> 9c8fa9bc08f6 ("kbuild: fix if_change and friends to consider argument
> order"), which no longer ignores the duplicate options. As Paulo
> Zanoni
> points out, the LDFLAGS_vmlinux variable has the same problem.
> 
> Reported-by: "Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
> Fixes: 9c8fa9bc08f6 ("kbuild: fix if_change and friends to consider
> argument order")
> Signed-off-by: Michal Marek <mmarek@suse.com>

Works for me.

Tested-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

Thanks a lot!

> ---
>  Makefile | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Makefile b/Makefile
> index 0f70de63cfdb..af0c463e908f 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -363,11 +363,13 @@ CHECK		= sparse
>  
>  CHECKFLAGS     := -D__linux__ -Dlinux -D__STDC__ -Dunix -D__unix__ \
>  		  -Wbitwise -Wno-return-void $(CF)
> +NOSTDINC_FLAGS  =
>  CFLAGS_MODULE   =
>  AFLAGS_MODULE   =
>  LDFLAGS_MODULE  =
>  CFLAGS_KERNEL	=
>  AFLAGS_KERNEL	=
> +LDFLAGS_vmlinux =
>  CFLAGS_GCOV	= -fprofile-arcs -ftest-coverage -fno-tree-loop-
> im -Wno-maybe-uninitialized
>  CFLAGS_KCOV	= -fsanitize-coverage=trace-pc
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Regression in "kbuild: fix if_change and friends to consider  argument order" "Zanoni, Paulo R" <paulo.r.zanoni@intel.com> - 2016-06-07 03:40 +0200
  Re: Regression in "kbuild: fix if_change and friends to consider  argument order" Michal Marek <mmarek@suse.com> - 2016-06-07 11:40 +0200
    Re: Regression in "kbuild: fix if_change and friends to consider  argument order" Michal Marek <mmarek@suse.cz> - 2016-06-07 12:00 +0200
      Re: Regression in "kbuild: fix if_change and friends to consider  argument order" Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-06-07 12:10 +0200
        Re: Regression in "kbuild: fix if_change and friends to consider  argument order" Michal Marek <mmarek@suse.cz> - 2016-06-07 12:50 +0200
          Re: Regression in "kbuild: fix if_change and friends to consider  argument order" Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-06-07 13:40 +0200
            Re: Regression in "kbuild: fix if_change and friends to consider  argument order" "Zanoni, Paulo R" <paulo.r.zanoni@intel.com> - 2016-06-07 16:20 +0200
              Re: Regression in "kbuild: fix if_change and friends to consider  argument order" Michal Marek <mmarek@suse.com> - 2016-06-08 00:00 +0200
                Re: Regression in "kbuild: fix if_change and friends to consider  argument order" "Zanoni, Paulo R" <paulo.r.zanoni@intel.com> - 2016-06-09 01:30 +0200

csiph-web