Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1417777

Re: [PATCH 00/18] staging/android: clean up SW_SYNC

Show all headers | View raw

Hi Greg,

Any comment on this?

	Gustavo

2016-05-31 Gustavo Padovan <gustavo@padovan.org>:

> From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> 
> Hi,
> 
> The following patches do a clean up on the sw_sync inteface. It starts by
> removing struct sync_timeline_ops, which was creating unecessary wrappers
> in the code and the start to organize the sync_timeline and sw_sync code
> better.
> 
> sw_sync interface was moved to sw_sync.c along with sync_timeline - which
> is now internal to sw_sync.
> 
> The next step after this work is the actual de-stage of SW_SYNC and
> the upstreaming of selftests for sw_sync and sync_file.
> 
> Please review!
> 
> 	Gustavo
> 
> ---
> 
> Gustavo Padovan (18):
>   staging/android: store last signaled value on sync timeline
>   staging/android: remove .{fence,timeline}_value_str() from timeline_ops
>   staging/android: remove struct sync_timeline_ops
>   staging/android: remove sw_sync_timeline and sw_sync_pt
>   staging/android: remove sw_sync.[ch] files
>   staging/android: rename android_fence to timeline_fence
>   staging/android: remove unnecessary check for fence
>   staging/android: remove size arg of sync_timeline_create()
>   staging/android: bring struct sync_pt back
>   staging/android: move sw_sync related code to sw_sync.c
>   staging/android: clean up #includes in the sync framework
>   staging/android: make sync_timeline internal to sw_sync
>   staging/android: make sw_ioctl info internal to sw_sync.c
>   staging/android: remove 'destroyed' member from struct sync_timeline
>   staging/android: remove sync_timeline_destroy()
>   staging/android: remove drv_name from sync_timeline
>   staging/android: rename sync.h to sync_debug.h
>   staging/android: add DEBUG_FS dependence on Kconfig
> 
>  drivers/staging/android/Kconfig        |  17 +-
>  drivers/staging/android/Makefile       |   3 +-
>  drivers/staging/android/sw_sync.c      | 341 ++++++++++++++++++++++++++++-----
>  drivers/staging/android/sw_sync.h      |  59 ------
>  drivers/staging/android/sync.c         | 221 ---------------------
>  drivers/staging/android/sync.h         | 154 ---------------
>  drivers/staging/android/sync_debug.c   | 154 +--------------
>  drivers/staging/android/sync_debug.h   |  83 ++++++++
>  drivers/staging/android/trace/sync.h   |  14 +-
>  drivers/staging/android/uapi/sw_sync.h |  32 ----
>  include/linux/fence.h                  |   2 -
>  11 files changed, 399 insertions(+), 681 deletions(-)
>  delete mode 100644 drivers/staging/android/sw_sync.h
>  delete mode 100644 drivers/staging/android/sync.c
>  delete mode 100644 drivers/staging/android/sync.h
>  create mode 100644 drivers/staging/android/sync_debug.h
>  delete mode 100644 drivers/staging/android/uapi/sw_sync.h
> 
> -- 
> 2.5.5
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/18] staging/android: clean up SW_SYNC Gustavo Padovan <gustavo@padovan.org> - 2016-05-31 22:00 +0200
  [PATCH 08/18] staging/android: remove size arg of sync_timeline_create() Gustavo Padovan <gustavo@padovan.org> - 2016-05-31 22:10 +0200
  [PATCH 16/18] staging/android: remove drv_name from sync_timeline Gustavo Padovan <gustavo@padovan.org> - 2016-05-31 22:10 +0200
  [PATCH 04/18] staging/android: remove sw_sync_timeline and sw_sync_pt Gustavo Padovan <gustavo@padovan.org> - 2016-05-31 22:10 +0200
  [PATCH 17/18] staging/android: rename sync.h to sync_debug.h Gustavo Padovan <gustavo@padovan.org> - 2016-05-31 22:10 +0200
  [PATCH 05/18] staging/android: remove sw_sync.[ch] files Gustavo Padovan <gustavo@padovan.org> - 2016-05-31 22:10 +0200
  [PATCH 13/18] staging/android: make sw_ioctl info internal to sw_sync.c Gustavo Padovan <gustavo@padovan.org> - 2016-05-31 22:10 +0200
  [PATCH 10/18] staging/android: move sw_sync related code to sw_sync.c Gustavo Padovan <gustavo@padovan.org> - 2016-05-31 22:10 +0200
  [PATCH 12/18] staging/android: make sync_timeline internal to sw_sync Gustavo Padovan <gustavo@padovan.org> - 2016-05-31 22:10 +0200
  [PATCH 07/18] staging/android: remove unnecessary check for fence Gustavo Padovan <gustavo@padovan.org> - 2016-05-31 22:10 +0200
  [PATCH 09/18] staging/android: bring struct sync_pt back Gustavo Padovan <gustavo@padovan.org> - 2016-05-31 22:10 +0200
  [PATCH 14/18] staging/android: remove 'destroyed' member from struct sync_timeline Gustavo Padovan <gustavo@padovan.org> - 2016-05-31 22:10 +0200
  [PATCH 18/18] staging/android: add DEBUG_FS dependence on Kconfig Gustavo Padovan <gustavo@padovan.org> - 2016-05-31 22:10 +0200
  [PATCH 02/18] staging/android: remove .{fence,timeline}_value_str() from timeline_ops Gustavo Padovan <gustavo@padovan.org> - 2016-05-31 22:10 +0200
  [PATCH 01/18] staging/android: store last signaled value on sync timeline Gustavo Padovan <gustavo@padovan.org> - 2016-05-31 22:10 +0200
  [PATCH 11/18] staging/android: clean up #includes in the sync framework Gustavo Padovan <gustavo@padovan.org> - 2016-05-31 22:10 +0200
  [PATCH 15/18] staging/android: remove sync_timeline_destroy() Gustavo Padovan <gustavo@padovan.org> - 2016-05-31 22:10 +0200
  [PATCH 03/18] staging/android: remove struct sync_timeline_ops Gustavo Padovan <gustavo@padovan.org> - 2016-05-31 22:10 +0200
  [PATCH 06/18] staging/android: rename android_fence to timeline_fence Gustavo Padovan <gustavo@padovan.org> - 2016-05-31 22:10 +0200
  Re: [PATCH 00/18] staging/android: clean up SW_SYNC Gustavo Padovan <gustavo@padovan.org> - 2016-06-08 21:10 +0200
    Re: [PATCH 00/18] staging/android: clean up SW_SYNC Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-06-09 07:50 +0200
      Re: [PATCH 00/18] staging/android: clean up SW_SYNC Daniel Vetter <daniel@ffwll.ch> - 2016-06-09 10:30 +0200
        Re: [PATCH 00/18] staging/android: clean up SW_SYNC Sumit Semwal <sumit.semwal@linaro.org> - 2016-06-09 16:00 +0200

csiph-web