Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1417052

[tip:perf/core] perf test: Ignore .scale and other special files

Show all headers | View raw

Commit-ID:  17a2634bcb88e52bd637fdaa47d7ff0bddb0188f
Gitweb:     http://git.kernel.org/tip/17a2634bcb88e52bd637fdaa47d7ff0bddb0188f
Author:     Andi Kleen <ak@linux.intel.com>
AuthorDate: Mon, 6 Jun 2016 07:36:06 -0700
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 6 Jun 2016 12:11:14 -0300

perf test: Ignore .scale and other special files

'perf test' tries to parse all entries in /sys/devices/cpu/events/.
Ignore the special entries like '.scale', which cannot be directly
parsed as an event. This patch assumes all files containing a '.' are
special and can be ignored.

Reported-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Link: http://lkml.kernel.org/r/1465223766-29902-1-git-send-email-andi@firstfloor.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/tests/parse-events.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/tests/parse-events.c b/tools/perf/tests/parse-events.c
index 7865f68..b2a2c74 100644
--- a/tools/perf/tests/parse-events.c
+++ b/tools/perf/tests/parse-events.c
@@ -1783,8 +1783,8 @@ static int test_pmu_events(void)
 		struct evlist_test e;
 		char name[MAX_NAME];
 
-		if (!strcmp(ent->d_name, ".") ||
-		    !strcmp(ent->d_name, ".."))
+		/* Names containing . are special and cannot be used directly */
+		if (strchr(ent->d_name, '.'))
 			continue;
 
 		snprintf(name, MAX_NAME, "cpu/event=%s/u", ent->d_name);

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] perf test: Ignore .scale and other special files Andi Kleen <andi@firstfloor.org> - 2016-06-06 16:40 +0200
  Re: [PATCH] perf test: Ignore .scale and other special files Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-06-06 17:00 +0200
    Re: [PATCH] perf test: Ignore .scale and other special files Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-06-06 17:20 +0200
      Re: [PATCH] perf test: Ignore .scale and other special files Andi Kleen <ak@linux.intel.com> - 2016-06-06 18:40 +0200
        Re: [PATCH] perf test: Ignore .scale and other special files Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-06-06 22:00 +0200
  Re: [PATCH] perf test: Ignore .scale and other special files Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-06-06 17:00 +0200
  [tip:perf/core] perf test: Ignore .scale and other special files tip-bot for Andi Kleen <tipbot@zytor.com> - 2016-06-08 10:40 +0200

csiph-web