Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1412516

Re: [PATCH] net: ethernet: wiznet: Remove create_workqueue

Show all headers | View raw

From: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Date: Wed, 1 Jun 2016 23:29:15 +0530

> alloc_workqueue replaces deprecated create_workqueue().
> 
> A dedicated workqueue has been used since the workitems are involved
> in normal device operation. Workitems &priv->rx_work and &priv->tx_work,
> map to w5100_rx_work and w5100_tx_work respectively and are involved in
> receiving and transmitting packets. Forward progress under
> memory pressure is a requirement here.
> 
> create_workqueue has been replaced with alloc_workqueue with max_active
> as 0 since there is no need for throttling the number of active work
> items.
> 
> Since the driver may be used in memory reclaim path,
> WQ_MEM_RECLAIM has been set to guarantee forward progress.
> 
> flush_workqueue is unnecessary since destroy_workqueue() itself calls
> drain_workqueue() which flushes repeatedly till the workqueue
> becomes empty. Hence the call to flush_workqueue() has been dropped.
> 
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>

Applied to net-next, thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] net: ethernet: wiznet: Remove create_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-06-01 20:00 +0200
  Re: [PATCH] net: ethernet: wiznet: Remove create_workqueue Tejun Heo <tj@kernel.org> - 2016-06-01 20:50 +0200
  Re: [PATCH] net: ethernet: wiznet: Remove create_workqueue David Miller <davem@davemloft.net> - 2016-06-02 21:20 +0200

csiph-web