Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1412515

Re: [PATCH] stmmac: do not sleep in atomic context for mdio_reset

Show all headers | View raw

From: Vincent Palatin <vpalatin@chromium.org>
Date: Wed,  1 Jun 2016 08:53:48 -0700

> stmmac_mdio_reset() has been updated to use msleep rather udelay
> (as some PHY requires a one second delay there).
> It called from stmmac_resume() within the spin_lock_irqsave block
> atomic context triggering 'scheduling while atomic'.
> 
> The stmmac_priv lock usage is not fully documented, but it seems
> to protect the access to the MAC registers / DMA structures rather
> than the MDIO bus or the PHY (which have separate locking),
> so we can push the spin_lock after the stmmac_mdio_reset call.
> 
> Signed-off-by: Vincent Palatin <vpalatin@chromium.org>

Applied, thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] stmmac: do not sleep in atomic context for mdio_reset Vincent Palatin <vpalatin@chromium.org> - 2016-06-01 18:00 +0200
  Re: [PATCH] stmmac: do not sleep in atomic context for mdio_reset David Miller <davem@davemloft.net> - 2016-06-02 21:20 +0200

csiph-web