Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1412395
| From | Bjorn Andersson <bjorn.andersson@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC PATCH v1 3/3] regulator: qcom_smd: add linear range to pm8941 lnldo |
| Date | 2016-06-02 18:10 +0200 |
| Message-ID | <rFDm1-82K-23@gated-at.bofh.it> (permalink) |
| References | <rFy2Z-4Jw-9@gated-at.bofh.it> <rFy2Z-4Jw-7@gated-at.bofh.it> <rFC6B-78u-3@gated-at.bofh.it> <rFCgh-7bC-9@gated-at.bofh.it> <rFDcl-7Kh-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu 02 Jun 08:50 PDT 2016, Mark Brown wrote: > On Thu, Jun 02, 2016 at 03:57:42PM +0100, Srinivas Kandagatla wrote: > > On 02/06/16 15:49, Mark Brown wrote: > > > > Why is this better than using a separate set of ops for the driver? > > > Am ok either way, it would be just few more lines for separate set of ops. > > It's more natural to use a separate set of ops, and we can optimise a > few things if we know the regulator is a fixed voltage one. In my view a fixed regulator is a thing that when you turn it on you get a predefined voltage, but iirc we actually need to send of a set-voltage request for the singly supported voltage on this ldo (which both implementations do today...). That's why I suggested Srini to do it this way, but maybe my interpretation of "fixed" is inaccurate? Regards, Bjorn
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC PATCH v1 3/3] regulator: qcom_smd: add linear range to pm8941 lnldo Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-06-02 12:30 +0200
Re: [RFC PATCH v1 3/3] regulator: qcom_smd: add linear range to pm8941 lnldo Mark Brown <broonie@kernel.org> - 2016-06-02 16:50 +0200
Re: [RFC PATCH v1 3/3] regulator: qcom_smd: add linear range to pm8941 lnldo Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-06-02 17:00 +0200
Re: [RFC PATCH v1 3/3] regulator: qcom_smd: add linear range to pm8941 lnldo Mark Brown <broonie@kernel.org> - 2016-06-02 18:00 +0200
Re: [RFC PATCH v1 3/3] regulator: qcom_smd: add linear range to pm8941 lnldo Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-06-02 18:10 +0200
Re: [RFC PATCH v1 3/3] regulator: qcom_smd: add linear range to pm8941 lnldo Mark Brown <broonie@kernel.org> - 2016-06-02 18:30 +0200
csiph-web