Re: [RFC PATCH v1 3/3] regulator: qcom_smd: add linear range to pm8941 lnldo

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH v1 3/3] regulator: qcom_smd: add linear range to pm8941 lnldo
Date	2016-06-02 18:30 +0200
Message-ID	<rFDFp-8bj-37@gated-at.bofh.it> (permalink)
References	(1 earlier) <rFy2Z-4Jw-7@gated-at.bofh.it> <rFC6B-78u-3@gated-at.bofh.it> <rFCgh-7bC-9@gated-at.bofh.it> <rFDcl-7Kh-7@gated-at.bofh.it> <rFDm1-82K-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu, Jun 02, 2016 at 09:04:32AM -0700, Bjorn Andersson wrote:
> On Thu 02 Jun 08:50 PDT 2016, Mark Brown wrote:

> > It's more natural to use a separate set of ops, and we can optimise a
> > few things if we know the regulator is a fixed voltage one.

> In my view a fixed regulator is a thing that when you turn it on you get
> a predefined voltage, but iirc we actually need to send of a set-voltage
> request for the singly supported voltage on this ldo (which both
> implementations do today...).

> That's why I suggested Srini to do it this way, but maybe my
> interpretation of "fixed" is inaccurate?

If it only supports one voltage then shouldn't we just tell it that
voltage once at startup?  Doing a call in the probe routine would be
fine, the framework doesn't need to know about that really.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC PATCH v1 3/3] regulator: qcom_smd: add linear range to pm8941 lnldo Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-06-02 12:30 +0200
  Re: [RFC PATCH v1 3/3] regulator: qcom_smd: add linear range to  pm8941 lnldo Mark Brown <broonie@kernel.org> - 2016-06-02 16:50 +0200
    Re: [RFC PATCH v1 3/3] regulator: qcom_smd: add linear range to  pm8941 lnldo Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-06-02 17:00 +0200
      Re: [RFC PATCH v1 3/3] regulator: qcom_smd: add linear range to  pm8941 lnldo Mark Brown <broonie@kernel.org> - 2016-06-02 18:00 +0200
        Re: [RFC PATCH v1 3/3] regulator: qcom_smd: add linear range to  pm8941 lnldo Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-06-02 18:10 +0200
          Re: [RFC PATCH v1 3/3] regulator: qcom_smd: add linear range to  pm8941 lnldo Mark Brown <broonie@kernel.org> - 2016-06-02 18:30 +0200

csiph-web