RE: [PATCH] mmc: host: use pr_err for sdhci_dumpregs

Path	csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	"Baranowska, BeataX" <beatax.baranowska@intel.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH] mmc: host: use pr_err for sdhci_dumpregs
Date	Wed, 01 Jun 2016 07:20:01 +0200
Message-ID	<rF6Jr-4ev-3@gated-at.bofh.it> (permalink)
References	<rEqhb-1fU-7@gated-at.bofh.it> <rEU5z-4yc-3@gated-at.bofh.it>
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.26,399,1459839600"; d="scan'208";a="992741192"
Thread-Topic	[PATCH] mmc: host: use pr_err for sdhci_dumpregs
Thread-Index	AdG2c7rzJ8O2ykHVRQ+gUr4IVaiuTQE14iMAAB4t6SA=
Accept-Language	en-US
Content-Language	en-US
X-Originating-IP	[163.33.239.181]
Content-Type	text/plain; charset="utf-8"
Content-Transfer-Encoding	base64
MIME-Version	1.0
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	18
Organization	linux.* mail to news gateway
X-Original-Cc	"Hunter, Adrian" <adrian.hunter@intel.com>, Ulf Hansson <ulf.hansson@linaro.org>, "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "Dong, Chuanxiao" <chuanxiao.dong@intel.com>, "Jarosz, SebastianX" <sebastianx.jarosz@intel.com>
X-Original-Date	Wed, 1 Jun 2016 05:12:59 +0000
X-Original-Message-ID	<CC22646CC0522A488A20F7A66BFD619308D8DB@irsmsx105.ger.corp.intel.com>
X-Original-References	<CC22646CC0522A488A20F7A66BFD619308D491@irsmsx105.ger.corp.intel.com> <CAHp75Veem2Dkrni8nYq7q-8h2GPUVQ-q7JOF_0OxDO6GGpSxCg@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1410822

Show key headers only | View raw

> -----Original Message-----
> From: Andy Shevchenko [mailto:andy.shevchenko@gmail.com]
> Sent: Tuesday, May 31, 2016 5:47 PM
> To: Baranowska, BeataX <beatax.baranowska@intel.com>
> Cc: Hunter, Adrian <adrian.hunter@intel.com>; Ulf Hansson
> <ulf.hansson@linaro.org>; linux-mmc@vger.kernel.org; linux-
> kernel@vger.kernel.org; Dong, Chuanxiao <chuanxiao.dong@intel.com>;
> Jarosz, SebastianX <sebastianx.jarosz@intel.com>
> Subject: Re: [PATCH] mmc: host: use pr_err for sdhci_dumpregs
> 
> On Mon, May 30, 2016 at 10:59 AM, Baranowska, BeataX
> <beatax.baranowska@intel.com> wrote:
> > From: Chuanxiao Dong <chuanxiao.dong@intel.com>
> >
> > sdhci_dumpregs is used to dump registers when error happens. Thus it
> > should use pr_err instead of pr_debug to show more information about
> the hardware.
> >
> 
> Wouldn't be too noisy?
> 
> --
> With Best Regards,
> Andy Shevchenko

It is when error happens so IMHO it should be well visible.

Regards,
Beata Baranowska

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] mmc: host: use pr_err for sdhci_dumpregs Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-05-31 17:50 +0200
  RE: [PATCH] mmc: host: use pr_err for sdhci_dumpregs "Baranowska, BeataX" <beatax.baranowska@intel.com> - 2016-06-01 07:20 +0200

csiph-web