RE: [PATCH] mmc: host: use pr_err for sdhci_dumpregs

From	"Baranowska, BeataX" <beatax.baranowska@intel.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH] mmc: host: use pr_err for sdhci_dumpregs
Date	2016-06-01 07:20 +0200
Message-ID	<rF6Jr-4ev-3@gated-at.bofh.it> (permalink)
References	<rEqhb-1fU-7@gated-at.bofh.it> <rEU5z-4yc-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> -----Original Message-----
> From: Andy Shevchenko [mailto:andy.shevchenko@gmail.com]
> Sent: Tuesday, May 31, 2016 5:47 PM
> To: Baranowska, BeataX <beatax.baranowska@intel.com>
> Cc: Hunter, Adrian <adrian.hunter@intel.com>; Ulf Hansson
> <ulf.hansson@linaro.org>; linux-mmc@vger.kernel.org; linux-
> kernel@vger.kernel.org; Dong, Chuanxiao <chuanxiao.dong@intel.com>;
> Jarosz, SebastianX <sebastianx.jarosz@intel.com>
> Subject: Re: [PATCH] mmc: host: use pr_err for sdhci_dumpregs
> 
> On Mon, May 30, 2016 at 10:59 AM, Baranowska, BeataX
> <beatax.baranowska@intel.com> wrote:
> > From: Chuanxiao Dong <chuanxiao.dong@intel.com>
> >
> > sdhci_dumpregs is used to dump registers when error happens. Thus it
> > should use pr_err instead of pr_debug to show more information about
> the hardware.
> >
> 
> Wouldn't be too noisy?
> 
> --
> With Best Regards,
> Andy Shevchenko

It is when error happens so IMHO it should be well visible.

Regards,
Beata Baranowska

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] mmc: host: use pr_err for sdhci_dumpregs Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-05-31 17:50 +0200
  RE: [PATCH] mmc: host: use pr_err for sdhci_dumpregs "Baranowska, BeataX" <beatax.baranowska@intel.com> - 2016-06-01 07:20 +0200

csiph-web