Groups > linux.kernel > #1410382 > unrolled thread

Re: [PATCH] mmc: host: use pr_err for sdhci_dumpregs

Started by	Andy Shevchenko <andy.shevchenko@gmail.com>
First post	2016-05-31 17:50 +0200
Last post	2016-06-01 07:20 +0200
Articles	2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

  Re: [PATCH] mmc: host: use pr_err for sdhci_dumpregs Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-05-31 17:50 +0200
    RE: [PATCH] mmc: host: use pr_err for sdhci_dumpregs "Baranowska, BeataX" <beatax.baranowska@intel.com> - 2016-06-01 07:20 +0200

#1410382 — Re: [PATCH] mmc: host: use pr_err for sdhci_dumpregs

From	Andy Shevchenko <andy.shevchenko@gmail.com>
Date	2016-05-31 17:50 +0200
Subject	Re: [PATCH] mmc: host: use pr_err for sdhci_dumpregs
Message-ID	<rEU5z-4yc-3@gated-at.bofh.it>

On Mon, May 30, 2016 at 10:59 AM, Baranowska, BeataX
<beatax.baranowska@intel.com> wrote:
> From: Chuanxiao Dong <chuanxiao.dong@intel.com>
>
> sdhci_dumpregs is used to dump registers when error happens. Thus it should
> use pr_err instead of pr_debug to show more information about the hardware.
>

Wouldn't be too noisy?

-- 
With Best Regards,
Andy Shevchenko

[toc] | [next] | [standalone]

#1410822

From	"Baranowska, BeataX" <beatax.baranowska@intel.com>
Date	2016-06-01 07:20 +0200
Message-ID	<rF6Jr-4ev-3@gated-at.bofh.it>
In reply to	#1410382

> -----Original Message-----
> From: Andy Shevchenko [mailto:andy.shevchenko@gmail.com]
> Sent: Tuesday, May 31, 2016 5:47 PM
> To: Baranowska, BeataX <beatax.baranowska@intel.com>
> Cc: Hunter, Adrian <adrian.hunter@intel.com>; Ulf Hansson
> <ulf.hansson@linaro.org>; linux-mmc@vger.kernel.org; linux-
> kernel@vger.kernel.org; Dong, Chuanxiao <chuanxiao.dong@intel.com>;
> Jarosz, SebastianX <sebastianx.jarosz@intel.com>
> Subject: Re: [PATCH] mmc: host: use pr_err for sdhci_dumpregs
> 
> On Mon, May 30, 2016 at 10:59 AM, Baranowska, BeataX
> <beatax.baranowska@intel.com> wrote:
> > From: Chuanxiao Dong <chuanxiao.dong@intel.com>
> >
> > sdhci_dumpregs is used to dump registers when error happens. Thus it
> > should use pr_err instead of pr_debug to show more information about
> the hardware.
> >
> 
> Wouldn't be too noisy?
> 
> --
> With Best Regards,
> Andy Shevchenko

It is when error happens so IMHO it should be well visible.

Regards,
Beata Baranowska

[toc] | [prev] | [standalone]

csiph-web

Re: [PATCH] mmc: host: use pr_err for sdhci_dumpregs

Contents

#1410382 — Re: [PATCH] mmc: host: use pr_err for sdhci_dumpregs

#1410822