Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1410564
| From | Krzysztof Kozlowski <krzk@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 4/6] ARM: dts: exynos: Add Thermal Management Unit to Exynos5410 |
| Date | 2016-05-31 21:30 +0200 |
| Message-ID | <rEXwu-6KR-17@gated-at.bofh.it> (permalink) |
| References | <rEWK5-6eV-19@gated-at.bofh.it> <rEWK5-6eV-21@gated-at.bofh.it> <rEXwu-6KR-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, May 31, 2016 at 9:21 PM, Javier Martinez Canillas
<javier@osg.samsung.com> wrote:
> Hello Krzysztof,
>
> On 05/31/2016 02:39 PM, Krzysztof Kozlowski wrote:
>> Add nodes for Thermal Management Unit to exynos5410.dtsi. Use the same
>> compatible as for Exynos5420 however without second base for TRIMINFO
>> register.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>> ---
>> arch/arm/boot/dts/exynos5410.dtsi | 55 +++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 55 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5410.dtsi b/arch/arm/boot/dts/exynos5410.dtsi
>> index 994d16a44fe4..f1effd3f03c4 100644
>> --- a/arch/arm/boot/dts/exynos5410.dtsi
>> +++ b/arch/arm/boot/dts/exynos5410.dtsi
>> @@ -81,6 +81,42 @@
>> #clock-cells = <1>;
>> };
>>
>> + tmu_cpu0: tmu@10060000 {
>> + compatible = "samsung,exynos5420-tmu";
>> + reg = <0x10060000 0x100>;
>> + interrupts = <0 65 0>;
>
> Please use GIC_SPI instead of 0 on these.
ok
>
>> + clocks = <&clock CLK_TMU>;
>> + clock-names = "tmu_apbif";
>> + #include "exynos4412-tmu-sensor-conf.dtsi"
>> + };
>> +
>> + tmu_cpu1: tmu@10064000 {
>> + compatible = "samsung,exynos5420-tmu";
>> + reg = <0x10064000 0x100>;
>> + interrupts = <0 183 0>;
>> + clocks = <&clock CLK_TMU>;
>> + clock-names = "tmu_apbif";
>> + #include "exynos4412-tmu-sensor-conf.dtsi"
>> + };
>> +
>> + tmu_cpu2: tmu@10068000 {
>> + compatible = "samsung,exynos5420-tmu";
>> + reg = <0x10068000 0x100>;
>> + interrupts = <0 184 0>;
>> + clocks = <&clock CLK_TMU>;
>> + clock-names = "tmu_apbif";
>> + #include "exynos4412-tmu-sensor-conf.dtsi"
>> + };
>> +
>> + tmu_cpu3: tmu@1006c000 {
>> + compatible = "samsung,exynos5420-tmu";
>> + reg = <0x1006c000 0x100>;
>> + interrupts = <0 185 0>;
>> + clocks = <&clock CLK_TMU>;
>> + clock-names = "tmu_apbif";
>> + #include "exynos4412-tmu-sensor-conf.dtsi"
>> + };
>> +
>
> Exynos5420 has 5 TMU channels and you are adding only 4 so I guess this
> is another difference with Exynos5410 besides the TRIMINFO register not
> being misplaced? Probably is worth to mention it in the commit message.
Yes, indeed there is no GPU thermal zone. I'll mention it.
Best regards,
Krzysztof
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/6] dt-bindings: clock: Add TMU clock ID to Exynos5410 Krzysztof Kozlowski <krzk@kernel.org> - 2016-05-31 20:40 +0200
[PATCH 4/6] ARM: dts: exynos: Add Thermal Management Unit to Exynos5410 Krzysztof Kozlowski <krzk@kernel.org> - 2016-05-31 20:40 +0200
Re: [PATCH 4/6] ARM: dts: exynos: Add Thermal Management Unit to Exynos5410 Javier Martinez Canillas <javier@osg.samsung.com> - 2016-05-31 21:30 +0200
Re: [PATCH 4/6] ARM: dts: exynos: Add Thermal Management Unit to Exynos5410 Krzysztof Kozlowski <krzk@kernel.org> - 2016-05-31 21:30 +0200
[PATCH 2/6] clk: samsung: exynos5410: Add TMU clock Krzysztof Kozlowski <krzk@kernel.org> - 2016-05-31 20:40 +0200
Re: [PATCH 2/6] clk: samsung: exynos5410: Add TMU clock Javier Martinez Canillas <javier@osg.samsung.com> - 2016-05-31 21:00 +0200
Re: [PATCH 2/6] clk: samsung: exynos5410: Add TMU clock Sylwester Nawrocki <s.nawrocki@samsung.com> - 2016-06-01 12:00 +0200
[PATCH 3/6] ARM: dts: exynos: Interrupt for USB DWC3-1 differs between Exynos5420 and 5410 Krzysztof Kozlowski <krzk@kernel.org> - 2016-05-31 20:40 +0200
Re: [PATCH 3/6] ARM: dts: exynos: Interrupt for USB DWC3-1 differs between Exynos5420 and 5410 Javier Martinez Canillas <javier@osg.samsung.com> - 2016-05-31 21:10 +0200
Re: [PATCH 3/6] ARM: dts: exynos: Interrupt for USB DWC3-1 differs between Exynos5420 and 5410 Krzysztof Kozlowski <krzk@kernel.org> - 2016-05-31 21:30 +0200
[PATCH 5/6] ARM: dts: exynos: Configure PWM, usb3503, PMIC and thermal on Odroid XU board Krzysztof Kozlowski <krzk@kernel.org> - 2016-05-31 20:50 +0200
Re: [PATCH 5/6] ARM: dts: exynos: Configure PWM, usb3503, PMIC and thermal on Odroid XU board Javier Martinez Canillas <javier@osg.samsung.com> - 2016-05-31 21:40 +0200
Re: [PATCH 5/6] ARM: dts: exynos: Configure PWM, usb3503, PMIC and thermal on Odroid XU board Krzysztof Kozlowski <krzk@kernel.org> - 2016-05-31 22:10 +0200
Re: [PATCH 5/6] ARM: dts: exynos: Configure PWM, usb3503, PMIC and thermal on Odroid XU board Javier Martinez Canillas <javier@osg.samsung.com> - 2016-05-31 22:20 +0200
[PATCH 6/6] ARM: dts: exynos: No need to enable TMU nodes on Odroid XU3 family Krzysztof Kozlowski <krzk@kernel.org> - 2016-05-31 20:50 +0200
Re: [PATCH 1/6] dt-bindings: clock: Add TMU clock ID to Exynos5410 Javier Martinez Canillas <javier@osg.samsung.com> - 2016-05-31 21:00 +0200
csiph-web