Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1410569
| From | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 5/6] ARM: dts: exynos: Configure PWM, usb3503, PMIC and thermal on Odroid XU board |
| Date | 2016-05-31 21:40 +0200 |
| Message-ID | <rEXGa-6O1-15@gated-at.bofh.it> (permalink) |
| References | <rEWK5-6eV-19@gated-at.bofh.it> <rEWTL-6iC-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hello Krzysztof,
On 05/31/2016 02:39 PM, Krzysztof Kozlowski wrote:
> Extend the DTS for Exynos5410-based Odroid XU board with:
> 1. Proper PWM outputs,
> 2. usb3503 USB HUB (with integrated LAN9730 ethernet adapter (smsc95xx)),
> 3. Maxim 77802 PMIC (regulators, 32 kHz clocks, RTC),
> 4. CPU thermal (trip points are the same as in Odroid XU3/XU4 but
> cooling maps are different as there is no CPU freq and only one
> cluster available for now),
> 5. Regulator supplies for USB 3.0.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> ---
>
[snip]
> +
> + ldo10_reg: LDO10 {
> + regulator-name = "vdd18_mipi";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-always-on;
> + };
> +
[snip]
> +
> + ldo12_reg: LDO12 {
> + regulator-name = "vdd33_usb3";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-always-on;
> + };
> +
[snip]
> +
> + ldo15_reg: LDO15 {
> + regulator-name = "vdd10_usb3";
> + regulator-min-microvolt = <1000000>;
> + regulator-max-microvolt = <1000000>;
> + regulator-always-on;
> + };
> +
I see that LDO 10, 12 and 15 are used by still marked as always-on. Did
you try not marking as always-on those or that also causes issues like
in the other regulators were you added comments about being always-on?
Besides that, patch looks good to me.
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/6] dt-bindings: clock: Add TMU clock ID to Exynos5410 Krzysztof Kozlowski <krzk@kernel.org> - 2016-05-31 20:40 +0200
[PATCH 4/6] ARM: dts: exynos: Add Thermal Management Unit to Exynos5410 Krzysztof Kozlowski <krzk@kernel.org> - 2016-05-31 20:40 +0200
Re: [PATCH 4/6] ARM: dts: exynos: Add Thermal Management Unit to Exynos5410 Javier Martinez Canillas <javier@osg.samsung.com> - 2016-05-31 21:30 +0200
Re: [PATCH 4/6] ARM: dts: exynos: Add Thermal Management Unit to Exynos5410 Krzysztof Kozlowski <krzk@kernel.org> - 2016-05-31 21:30 +0200
[PATCH 2/6] clk: samsung: exynos5410: Add TMU clock Krzysztof Kozlowski <krzk@kernel.org> - 2016-05-31 20:40 +0200
Re: [PATCH 2/6] clk: samsung: exynos5410: Add TMU clock Javier Martinez Canillas <javier@osg.samsung.com> - 2016-05-31 21:00 +0200
Re: [PATCH 2/6] clk: samsung: exynos5410: Add TMU clock Sylwester Nawrocki <s.nawrocki@samsung.com> - 2016-06-01 12:00 +0200
[PATCH 3/6] ARM: dts: exynos: Interrupt for USB DWC3-1 differs between Exynos5420 and 5410 Krzysztof Kozlowski <krzk@kernel.org> - 2016-05-31 20:40 +0200
Re: [PATCH 3/6] ARM: dts: exynos: Interrupt for USB DWC3-1 differs between Exynos5420 and 5410 Javier Martinez Canillas <javier@osg.samsung.com> - 2016-05-31 21:10 +0200
Re: [PATCH 3/6] ARM: dts: exynos: Interrupt for USB DWC3-1 differs between Exynos5420 and 5410 Krzysztof Kozlowski <krzk@kernel.org> - 2016-05-31 21:30 +0200
[PATCH 5/6] ARM: dts: exynos: Configure PWM, usb3503, PMIC and thermal on Odroid XU board Krzysztof Kozlowski <krzk@kernel.org> - 2016-05-31 20:50 +0200
Re: [PATCH 5/6] ARM: dts: exynos: Configure PWM, usb3503, PMIC and thermal on Odroid XU board Javier Martinez Canillas <javier@osg.samsung.com> - 2016-05-31 21:40 +0200
Re: [PATCH 5/6] ARM: dts: exynos: Configure PWM, usb3503, PMIC and thermal on Odroid XU board Krzysztof Kozlowski <krzk@kernel.org> - 2016-05-31 22:10 +0200
Re: [PATCH 5/6] ARM: dts: exynos: Configure PWM, usb3503, PMIC and thermal on Odroid XU board Javier Martinez Canillas <javier@osg.samsung.com> - 2016-05-31 22:20 +0200
[PATCH 6/6] ARM: dts: exynos: No need to enable TMU nodes on Odroid XU3 family Krzysztof Kozlowski <krzk@kernel.org> - 2016-05-31 20:50 +0200
Re: [PATCH 1/6] dt-bindings: clock: Add TMU clock ID to Exynos5410 Javier Martinez Canillas <javier@osg.samsung.com> - 2016-05-31 21:00 +0200
csiph-web