Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1410558

Re: [PATCH 3/6] ARM: dts: exynos: Interrupt for USB DWC3-1 differs between Exynos5420 and 5410

Show all headers | View raw

On Tue, May 31, 2016 at 9:01 PM, Javier Martinez Canillas
<javier@osg.samsung.com> wrote:
> Hello Krzysztof,
>
> On 05/31/2016 02:39 PM, Krzysztof Kozlowski wrote:
>> On Exynos5410 the SPI interrupt for second USB DWC3 (called DRD: Dual
>> Role Device) is different - 200 instead of 73.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>> ---
>>  arch/arm/boot/dts/exynos5410.dtsi | 4 ++++
>>  arch/arm/boot/dts/exynos5420.dtsi | 4 ++++
>>  arch/arm/boot/dts/exynos54xx.dtsi | 1 -
>>  3 files changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5410.dtsi b/arch/arm/boot/dts/exynos5410.dtsi
>> index a937d9bdad90..994d16a44fe4 100644
>> --- a/arch/arm/boot/dts/exynos5410.dtsi
>> +++ b/arch/arm/boot/dts/exynos5410.dtsi
>> @@ -267,6 +267,10 @@
>>       clock-names = "usbdrd30";
>>  };
>>
>> +&usbdrd_dwc3_1 {
>> +     interrupts = <0 200 0>;
>
> Please use GIC_SPI from <dt-bindings/interrupt-controller/arm-gic.h> instead 0.
>
> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>

Sure, thanks for feedback.

Krzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/6] dt-bindings: clock: Add TMU clock ID to Exynos5410 Krzysztof Kozlowski <krzk@kernel.org> - 2016-05-31 20:40 +0200
  [PATCH 4/6] ARM: dts: exynos: Add Thermal Management Unit to Exynos5410 Krzysztof Kozlowski <krzk@kernel.org> - 2016-05-31 20:40 +0200
    Re: [PATCH 4/6] ARM: dts: exynos: Add Thermal Management Unit to  Exynos5410 Javier Martinez Canillas <javier@osg.samsung.com> - 2016-05-31 21:30 +0200
      Re: [PATCH 4/6] ARM: dts: exynos: Add Thermal Management Unit to Exynos5410 Krzysztof Kozlowski <krzk@kernel.org> - 2016-05-31 21:30 +0200
  [PATCH 2/6] clk: samsung: exynos5410: Add TMU clock Krzysztof Kozlowski <krzk@kernel.org> - 2016-05-31 20:40 +0200
    Re: [PATCH 2/6] clk: samsung: exynos5410: Add TMU clock Javier Martinez Canillas <javier@osg.samsung.com> - 2016-05-31 21:00 +0200
      Re: [PATCH 2/6] clk: samsung: exynos5410: Add TMU clock Sylwester Nawrocki <s.nawrocki@samsung.com> - 2016-06-01 12:00 +0200
  [PATCH 3/6] ARM: dts: exynos: Interrupt for USB DWC3-1 differs between Exynos5420 and 5410 Krzysztof Kozlowski <krzk@kernel.org> - 2016-05-31 20:40 +0200
    Re: [PATCH 3/6] ARM: dts: exynos: Interrupt for USB DWC3-1 differs  between Exynos5420 and 5410 Javier Martinez Canillas <javier@osg.samsung.com> - 2016-05-31 21:10 +0200
      Re: [PATCH 3/6] ARM: dts: exynos: Interrupt for USB DWC3-1 differs  between Exynos5420 and 5410 Krzysztof Kozlowski <krzk@kernel.org> - 2016-05-31 21:30 +0200
  [PATCH 5/6] ARM: dts: exynos: Configure PWM, usb3503, PMIC and thermal on Odroid XU board Krzysztof Kozlowski <krzk@kernel.org> - 2016-05-31 20:50 +0200
    Re: [PATCH 5/6] ARM: dts: exynos: Configure PWM, usb3503, PMIC and  thermal on Odroid XU board Javier Martinez Canillas <javier@osg.samsung.com> - 2016-05-31 21:40 +0200
      Re: [PATCH 5/6] ARM: dts: exynos: Configure PWM, usb3503, PMIC and  thermal on Odroid XU board Krzysztof Kozlowski <krzk@kernel.org> - 2016-05-31 22:10 +0200
        Re: [PATCH 5/6] ARM: dts: exynos: Configure PWM, usb3503, PMIC and  thermal on Odroid XU board Javier Martinez Canillas <javier@osg.samsung.com> - 2016-05-31 22:20 +0200
  [PATCH 6/6] ARM: dts: exynos: No need to enable TMU nodes on Odroid XU3 family Krzysztof Kozlowski <krzk@kernel.org> - 2016-05-31 20:50 +0200
  Re: [PATCH 1/6] dt-bindings: clock: Add TMU clock ID to Exynos5410 Javier Martinez Canillas <javier@osg.samsung.com> - 2016-05-31 21:00 +0200

csiph-web