Re: [RFT PATCH 1/2] serial: Fix console setup section mismatch

Path	csiph.com!goblin2!goblin1!goblin.stu.neva.ru!news2.arglkargh.de!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Krzysztof Kozlowski <k.kozlowski@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [RFT PATCH 1/2] serial: Fix console setup section mismatch
Date	Tue, 31 May 2016 16:40:01 +0200
Message-ID	<rESZP-3TI-19@gated-at.bofh.it> (permalink)
References	<rESQ9-3QA-7@gated-at.bofh.it> <rESQ9-3QA-13@gated-at.bofh.it>
X-Auditid	cbfec7f4-f796c6d000001486-a2-574da10a9793
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0
MIME-Version	1.0
Content-Type	text/plain; charset=windows-1252
Content-Transfer-Encoding	7bit
X-Brightmail-Tracker	H4sIAAAAAAAAA02SWUhUYRiG+eecOec4NXKcXH4MFCbqwtASJf9MKiPoJ1y60NG6sUlPJrlx RiUjaHA00VTSLGRSc8stbVzJLbUx90plXBBMDTWXtMzERNFJZ4i8e3m/53mvPoaQ6ElrJiQ8 iuPD5aFSSkT273YP24vyPf1Oj2WYou4qJYX0vU6oOksjRLPaVAKtxiUQKHsgnkTf81IBUhVq KJRZtSpA3xccUc3MqBClt32ika4pm0IfC1NptFQ8A5D22TuA4nWlBNr+sytEA/MrJPqx6I/q lFoKbehUNEpWz1Go4kMhjTK0PJqoV1FovKGWRsreUiFqb98BSL+lIi7a4KURd6wbHSJw3lY9 ievKxgV4uK+fxgWLShI3qr/QOGU5XohrypMoPDHaQuHOskoBbsupoHFt0UM8kJUP8EhJkQA3 5/0WXLO6IXIL4kJDYjj+1PmbojuNrT1EZC59b7B0g1SCGWEyMGEg6ww79G2EMVvCwUkNtZ8l 7CsAczOOJQPRXv4GYMnzPsPhCHsFzlcYIfM9uev9OmkUYuHQ2Di5LxDsCAMn36QZVinWCdaW FBkEMWsHl/RvDJlkj8O4lG6DbMH6Q/XbTYGRMYObTycNvQnrBjuTNHs7zN6oA5wastuvCdYW 1lasEE8Aqz5gqP9T6gNUHiDKgQUXHRipuBUc5uigkIcposODHQIjwmqA8S3WG0Bhl6sWsAyQ HhZff+zhJxHKYxSxYVoAGUJqLl546eknEQfJY+9zfEQAHx3KKbTgKENKrcQ5TT99JGywPIq7 y3GRHP/vKmBMrJXg0XqQ7qyH7et0bqhEM93Rc1n91T7yUHXnNFatyZzd+lUBVz1d3SYjWuba Wl/88r2U5j0b54Vdgqg1AZ/h432bX30wZVlg5tVse+LCtnyNtT1n/XmjsdK+IHNe5WvqLAs3 lfUmZlfmBrr4F7vLRs44yeiT5QnNSSEfEq2WfXZspKTijtzRjuAV8r/xwBLTEgMAAA==
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	21
Organization	linux.* mail to news gateway
X-Original-Cc	Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jiri Slaby <jslaby@suse.com>, Tobias Klauser <tklauser@distanz.ch>, Nicolas Ferre <nicolas.ferre@atmel.com>, Sonic Zhang <sonic.zhang@analog.com>, "Maciej W. Rozycki" <macro@linux-mips.org>, Vladimir Zapolskiy <vz@mleia.com>, Sylvain Lemieux <slemieux.tyco@gmail.com>, Andy Gross <andy.gross@linaro.org>, David Brown <david.brown@linaro.org>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Paul Mackerras <paulus@samba.org>, Michael Ellerman <mpe@ellerman.id.au>, Barry Song <baohua@kernel.org>, "David S. Miller" <davem@davemloft.net>, Tony Prisk <linux@prisktech.co.nz>, Michal Simek <michal.simek@xilinx.com>, Sören Brinkmann <soren.brinkmann@xilinx.com>, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, nios2-dev@lists.rocketboards.org, adi-buildroot-devel@lists.sourceforge.net, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
X-Original-Date	Tue, 31 May 2016 16:34:47 +0200
X-Original-Message-ID	<574DA107.8050002@samsung.com>
X-Original-References	<1464704372-17668-1-git-send-email-k.kozlowski@samsung.com> <20160531142142.GX19428@n2100.arm.linux.org.uk>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1410355

Show key headers only | View raw

On 05/31/2016 04:21 PM, Russell King - ARM Linux wrote:
> On Tue, May 31, 2016 at 04:19:31PM +0200, Krzysztof Kozlowski wrote:
>> Remove __init annotation from all of console->setup implementations
>> because:
>> 1. The pointer to it is stored in a struct console which is not
>>    marked with __initdata.
>> 2. It is referenced by register_console() from kernel which is not
>>    marked with __init.
> 
> However, many of these drivers, the console can only be used when the
> driver is built-in, and register_console() is only called early in
> initialisation.

Indeed so maybe the word "fix" in commit subject is not proper because
there might be no error at all. My point is that current solution is a
little bit non-obvious and an error might happen. If we were sure that
register_console() is called only from other __init functions, then it
should be made also __init.

Best regards,
Krzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFT PATCH 1/2] serial: Fix console setup section mismatch Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-05-31 16:30 +0200
  Re: [RFT PATCH 1/2] serial: Fix console setup section mismatch Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-05-31 16:40 +0200

csiph-web