Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1410347 > unrolled thread
| Started by | Russell King - ARM Linux <linux@armlinux.org.uk> |
|---|---|
| First post | 2016-05-31 16:30 +0200 |
| Last post | 2016-05-31 16:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [RFT PATCH 1/2] serial: Fix console setup section mismatch Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-05-31 16:30 +0200
Re: [RFT PATCH 1/2] serial: Fix console setup section mismatch Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-05-31 16:40 +0200
| From | Russell King - ARM Linux <linux@armlinux.org.uk> |
|---|---|
| Date | 2016-05-31 16:30 +0200 |
| Subject | Re: [RFT PATCH 1/2] serial: Fix console setup section mismatch |
| Message-ID | <rESQ9-3QA-13@gated-at.bofh.it> |
On Tue, May 31, 2016 at 04:19:31PM +0200, Krzysztof Kozlowski wrote: > Remove __init annotation from all of console->setup implementations > because: > 1. The pointer to it is stored in a struct console which is not > marked with __initdata. > 2. It is referenced by register_console() from kernel which is not > marked with __init. However, many of these drivers, the console can only be used when the driver is built-in, and register_console() is only called early in initialisation. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.
[toc] | [next] | [standalone]
| From | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| Date | 2016-05-31 16:40 +0200 |
| Message-ID | <rESZP-3TI-19@gated-at.bofh.it> |
| In reply to | #1410347 |
On 05/31/2016 04:21 PM, Russell King - ARM Linux wrote: > On Tue, May 31, 2016 at 04:19:31PM +0200, Krzysztof Kozlowski wrote: >> Remove __init annotation from all of console->setup implementations >> because: >> 1. The pointer to it is stored in a struct console which is not >> marked with __initdata. >> 2. It is referenced by register_console() from kernel which is not >> marked with __init. > > However, many of these drivers, the console can only be used when the > driver is built-in, and register_console() is only called early in > initialisation. Indeed so maybe the word "fix" in commit subject is not proper because there might be no error at all. My point is that current solution is a little bit non-obvious and an error might happen. If we were sure that register_console() is called only from other __init functions, then it should be made also __init. Best regards, Krzysztof
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web