Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1410355

Re: [RFT PATCH 1/2] serial: Fix console setup section mismatch

Show all headers | View raw

On 05/31/2016 04:21 PM, Russell King - ARM Linux wrote:
> On Tue, May 31, 2016 at 04:19:31PM +0200, Krzysztof Kozlowski wrote:
>> Remove __init annotation from all of console->setup implementations
>> because:
>> 1. The pointer to it is stored in a struct console which is not
>>    marked with __initdata.
>> 2. It is referenced by register_console() from kernel which is not
>>    marked with __init.
> 
> However, many of these drivers, the console can only be used when the
> driver is built-in, and register_console() is only called early in
> initialisation.

Indeed so maybe the word "fix" in commit subject is not proper because
there might be no error at all. My point is that current solution is a
little bit non-obvious and an error might happen. If we were sure that
register_console() is called only from other __init functions, then it
should be made also __init.

Best regards,
Krzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFT PATCH 1/2] serial: Fix console setup section mismatch Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-05-31 16:30 +0200
  Re: [RFT PATCH 1/2] serial: Fix console setup section mismatch Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-05-31 16:40 +0200

csiph-web