Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1410032
| Path | csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Peter Zijlstra <peterz@infradead.org> |
| Newsgroups | linux.kernel |
| Subject | Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched domain build-up |
| Date | Tue, 31 May 2016 11:30:01 +0200 |
| Message-ID | <rEO9P-Rc-7@gated-at.bofh.it> (permalink) |
| References | <rENQt-Jk-17@gated-at.bofh.it> <rENQu-Jk-21@gated-at.bofh.it> |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=us-ascii |
| Content-Disposition | inline |
| User-Agent | Mutt/1.5.21 (2012-12-30) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 32 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | mingo@kernel.org, linux-kernel@vger.kernel.org, umgwanakikbuti@gmail.com, bsegall@google.com, pjt@google.com, morten.rasmussen@arm.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com |
| X-Original-Date | Tue, 31 May 2016 11:21:46 +0200 |
| X-Original-Message-ID | <20160531092146.GT3192@twins.programming.kicks-ass.net> |
| X-Original-References | <1464657098-24880-1-git-send-email-yuyang.du@intel.com> <1464657098-24880-2-git-send-email-yuyang.du@intel.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1410032 |
Show key headers only | View raw
On Tue, May 31, 2016 at 09:11:37AM +0800, Yuyang Du wrote:
> The SD_BALANCE_WAKE is irrelevant in the contexts of these two removals,
> and in addition SD_BALANCE_WAKE is not and should not be set in any
> sched_domain flags so far.
This Changelog doesn't make any sense...
> Signed-off-by: Yuyang Du <yuyang.du@intel.com>
> ---
> kernel/sched/core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 7f2cae4..e00b8ea 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -6229,10 +6229,10 @@ static void set_domain_attribute(struct sched_domain *sd,
> request = attr->relax_domain_level;
> if (request < sd->level) {
> /* turn off idle balance on this domain */
> - sd->flags &= ~(SD_BALANCE_WAKE|SD_BALANCE_NEWIDLE);
> + sd->flags &= ~(SD_BALANCE_NEWIDLE);
> } else {
> /* turn on idle balance on this domain */
> - sd->flags |= (SD_BALANCE_WAKE|SD_BALANCE_NEWIDLE);
> + sd->flags |= (SD_BALANCE_NEWIDLE);
> }
> }
>
> --
> 1.7.9.5
>
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[RFC PATCH 0/2] Remove and replace SD_WAKE_AFFINE with SD_BALANCE_WAKE Yuyang Du <yuyang.du@intel.com> - 2016-05-31 11:10 +0200
[RFC PATCH 2/2] sched: Remove SD_WAKE_AFFINE flag and replace it with SD_BALANCE_WAKE Yuyang Du <yuyang.du@intel.com> - 2016-05-31 11:10 +0200
Re: [RFC PATCH 2/2] sched: Remove SD_WAKE_AFFINE flag and replace it with SD_BALANCE_WAKE Peter Zijlstra <peterz@infradead.org> - 2016-05-31 11:30 +0200
Re: [RFC PATCH 2/2] sched: Remove SD_WAKE_AFFINE flag and replace it with SD_BALANCE_WAKE Yuyang Du <yuyang.du@intel.com> - 2016-05-31 11:40 +0200
[RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched domain build-up Yuyang Du <yuyang.du@intel.com> - 2016-05-31 11:10 +0200
Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched domain build-up Yuyang Du <yuyang.du@intel.com> - 2016-05-31 11:30 +0200
Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched domain build-up Peter Zijlstra <peterz@infradead.org> - 2016-05-31 12:50 +0200
Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched domain build-up Yuyang Du <yuyang.du@intel.com> - 2016-06-01 04:00 +0200
Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched domain build-up Mike Galbraith <umgwanakikbuti@gmail.com> - 2016-06-01 07:10 +0200
Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched domain build-up Yuyang Du <yuyang.du@intel.com> - 2016-06-01 10:00 +0200
Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched domain build-up Vincent Guittot <vincent.guittot@linaro.org> - 2016-06-01 10:40 +0200
Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched domain build-up Yuyang Du <yuyang.du@intel.com> - 2016-06-01 11:10 +0200
Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched domain build-up Vincent Guittot <vincent.guittot@linaro.org> - 2016-06-01 11:30 +0200
Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched domain build-up Yuyang Du <yuyang.du@intel.com> - 2016-06-02 05:40 +0200
Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched domain build-up Vincent Guittot <vincent.guittot@linaro.org> - 2016-06-02 09:00 +0200
Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched domain build-up Yuyang Du <yuyang.du@intel.com> - 2016-06-02 09:20 +0200
Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched domain build-up Mike Galbraith <umgwanakikbuti@gmail.com> - 2016-06-01 11:40 +0200
Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched domain build-up Yuyang Du <yuyang.du@intel.com> - 2016-06-02 06:10 +0200
Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched domain build-up Mike Galbraith <umgwanakikbuti@gmail.com> - 2016-06-02 08:00 +0200
Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched domain build-up Yuyang Du <yuyang.du@intel.com> - 2016-06-02 08:40 +0200
Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched domain build-up Mike Galbraith <umgwanakikbuti@gmail.com> - 2016-06-02 08:50 +0200
Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched domain build-up Peter Zijlstra <peterz@infradead.org> - 2016-05-31 11:30 +0200
csiph-web