Path: csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod From: Peter Zijlstra Newsgroups: linux.kernel Subject: Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched domain build-up Date: Tue, 31 May 2016 11:30:01 +0200 Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2012-12-30) Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 32 Organization: linux.* mail to news gateway X-Original-Cc: mingo@kernel.org, linux-kernel@vger.kernel.org, umgwanakikbuti@gmail.com, bsegall@google.com, pjt@google.com, morten.rasmussen@arm.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com X-Original-Date: Tue, 31 May 2016 11:21:46 +0200 X-Original-Message-ID: <20160531092146.GT3192@twins.programming.kicks-ass.net> X-Original-References: <1464657098-24880-1-git-send-email-yuyang.du@intel.com> <1464657098-24880-2-git-send-email-yuyang.du@intel.com> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1410032 On Tue, May 31, 2016 at 09:11:37AM +0800, Yuyang Du wrote: > The SD_BALANCE_WAKE is irrelevant in the contexts of these two removals, > and in addition SD_BALANCE_WAKE is not and should not be set in any > sched_domain flags so far. This Changelog doesn't make any sense... > Signed-off-by: Yuyang Du > --- > kernel/sched/core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > index 7f2cae4..e00b8ea 100644 > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -6229,10 +6229,10 @@ static void set_domain_attribute(struct sched_domain *sd, > request = attr->relax_domain_level; > if (request < sd->level) { > /* turn off idle balance on this domain */ > - sd->flags &= ~(SD_BALANCE_WAKE|SD_BALANCE_NEWIDLE); > + sd->flags &= ~(SD_BALANCE_NEWIDLE); > } else { > /* turn on idle balance on this domain */ > - sd->flags |= (SD_BALANCE_WAKE|SD_BALANCE_NEWIDLE); > + sd->flags |= (SD_BALANCE_NEWIDLE); > } > } > > -- > 1.7.9.5 >