Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1410132

Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched domain build-up

From Peter Zijlstra <peterz@infradead.org>
Newsgroups linux.kernel
Subject Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched domain build-up
Date 2016-05-31 12:50 +0200
Message-ID <rEPpf-1AT-7@gated-at.bofh.it> (permalink)
References <rENQt-Jk-17@gated-at.bofh.it> <rENQu-Jk-21@gated-at.bofh.it> <rEO9P-Rc-7@gated-at.bofh.it> <rEO9P-Rc-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Tue, May 31, 2016 at 09:31:32AM +0800, Yuyang Du wrote:
> On Tue, May 31, 2016 at 11:21:46AM +0200, Peter Zijlstra wrote:
> > On Tue, May 31, 2016 at 09:11:37AM +0800, Yuyang Du wrote:
> > > The SD_BALANCE_WAKE is irrelevant in the contexts of these two removals,
> > > and in addition SD_BALANCE_WAKE is not and should not be set in any
> > > sched_domain flags so far.
> > 
> > This Changelog doesn't make any sense...
> 
> How? SD_BALANCE_WAKE is not in any sched_domain flags (sd->flags), even if
> it is, it is not used anywhere, no?

It is and it is. See select_task_fair_rq():

	if (tmp->flags & sd_flags)

Now, as long as WAKE_AFFINE is also set, its hard to actually get into
the find_idlest_cpu() balancing, but if you clear all that you will
still get there.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH 0/2] Remove and replace SD_WAKE_AFFINE with SD_BALANCE_WAKE Yuyang Du <yuyang.du@intel.com> - 2016-05-31 11:10 +0200
  [RFC PATCH 2/2] sched: Remove SD_WAKE_AFFINE flag and replace it with SD_BALANCE_WAKE Yuyang Du <yuyang.du@intel.com> - 2016-05-31 11:10 +0200
    Re: [RFC PATCH 2/2] sched: Remove SD_WAKE_AFFINE flag and replace it  with SD_BALANCE_WAKE Peter Zijlstra <peterz@infradead.org> - 2016-05-31 11:30 +0200
      Re: [RFC PATCH 2/2] sched: Remove SD_WAKE_AFFINE flag and replace it  with SD_BALANCE_WAKE Yuyang Du <yuyang.du@intel.com> - 2016-05-31 11:40 +0200
  [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched domain build-up Yuyang Du <yuyang.du@intel.com> - 2016-05-31 11:10 +0200
    Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched  domain build-up Yuyang Du <yuyang.du@intel.com> - 2016-05-31 11:30 +0200
      Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched  domain build-up Peter Zijlstra <peterz@infradead.org> - 2016-05-31 12:50 +0200
        Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched  domain build-up Yuyang Du <yuyang.du@intel.com> - 2016-06-01 04:00 +0200
      Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched  domain build-up Mike Galbraith <umgwanakikbuti@gmail.com> - 2016-06-01 07:10 +0200
        Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched  domain build-up Yuyang Du <yuyang.du@intel.com> - 2016-06-01 10:00 +0200
          Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched  domain build-up Vincent Guittot <vincent.guittot@linaro.org> - 2016-06-01 10:40 +0200
            Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched  domain build-up Yuyang Du <yuyang.du@intel.com> - 2016-06-01 11:10 +0200
              Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched  domain build-up Vincent Guittot <vincent.guittot@linaro.org> - 2016-06-01 11:30 +0200
                Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched  domain build-up Yuyang Du <yuyang.du@intel.com> - 2016-06-02 05:40 +0200
                Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched  domain build-up Vincent Guittot <vincent.guittot@linaro.org> - 2016-06-02 09:00 +0200
                Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched  domain build-up Yuyang Du <yuyang.du@intel.com> - 2016-06-02 09:20 +0200
          Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched  domain build-up Mike Galbraith <umgwanakikbuti@gmail.com> - 2016-06-01 11:40 +0200
            Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched  domain build-up Yuyang Du <yuyang.du@intel.com> - 2016-06-02 06:10 +0200
              Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched  domain build-up Mike Galbraith <umgwanakikbuti@gmail.com> - 2016-06-02 08:00 +0200
                Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched  domain build-up Yuyang Du <yuyang.du@intel.com> - 2016-06-02 08:40 +0200
                Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched  domain build-up Mike Galbraith <umgwanakikbuti@gmail.com> - 2016-06-02 08:50 +0200
    Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched  domain build-up Peter Zijlstra <peterz@infradead.org> - 2016-05-31 11:30 +0200

csiph-web