Re: [PATCH] Add virtio gpu driver.

From	Daniel Vetter <daniel@ffwll.ch>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Add virtio gpu driver.
Date	2016-05-31 09:00 +0200
Message-ID	<rELOG-7tj-13@gated-at.bofh.it> (permalink)
References	(5 earlier) <rDkGR-yd-11@gated-at.bofh.it> <rDlWi-1vV-5@gated-at.bofh.it> <rEvTz-4U9-1@gated-at.bofh.it> <rEwFX-5sh-21@gated-at.bofh.it> <rELlG-7d7-65@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, May 31, 2016 at 8:29 AM, Gerd Hoffmann <kraxel@redhat.com> wrote:
>>  but it also means that
>> atomic userspace can't use hotspots before we add properties to fbs. And
>> doing that is a bit tricky since drm_framebuffer objects are meant to be
>> invariant - this assumption is deeply in-grained into the code all over
>> the place, everything just compares pointers when semantically it means to
>> compare the entire fb (including backing storage pointer/offsets and
>> everything).
>
> Hmm, the hotspot location for a given cursor image is invariant too, so
> I don't think that would be a big issue.
>
> I'd expect userspace define a bunch of cursors, then switch between them
> (instead of defining a single cursor, then constantly updating it).

Agreed, conceptually it would be a really nice fit to put the hotspot
into the invariant drm_framebuffer. I just meant to say that you need
to add a bit of new uapi to make it happen, since we can't reuse our
existing get/set_prop functions (since those only change props after
the object is created). And we also can't use our existing ioctls to
enumerate properties of an object (since chicken-egg: you want the
list of properties before creating a new framebuffer, so can't use
that framebuffer to enumerate them).

But really not a big concern.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

Thread

Re: [PATCH] Add virtio gpu driver. Daniel Vetter <daniel@ffwll.ch> - 2016-05-25 18:50 +0200
  Re: [PATCH] Add virtio gpu driver. Emil Velikov <emil.l.velikov@gmail.com> - 2016-05-25 18:50 +0200
  Re: [PATCH] Add virtio gpu driver. Gerd Hoffmann <kraxel@redhat.com> - 2016-05-27 09:50 +0200
    Re: [PATCH] Add virtio gpu driver. Daniel Vetter <daniel@ffwll.ch> - 2016-05-27 11:10 +0200
      Re: [PATCH] Add virtio gpu driver. Gerd Hoffmann <kraxel@redhat.com> - 2016-05-30 16:00 +0200
        Re: [PATCH] Add virtio gpu driver. Daniel Vetter <daniel@ffwll.ch> - 2016-05-30 16:50 +0200
          Re: [PATCH] Add virtio gpu driver. Gerd Hoffmann <kraxel@redhat.com> - 2016-05-31 08:30 +0200
            Re: [PATCH] Add virtio gpu driver. Daniel Vetter <daniel@ffwll.ch> - 2016-05-31 09:00 +0200
            Re: [PATCH] Add virtio gpu driver. Pekka Paalanen <ppaalanen@gmail.com> - 2016-05-31 09:10 +0200

csiph-web