Re: [PATCH] Add virtio gpu driver.

From	Daniel Vetter <daniel@ffwll.ch>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Add virtio gpu driver.
Date	2016-05-25 18:50 +0200
Message-ID	<rCKal-3fR-5@gated-at.bofh.it> (permalink)
References	<p7zyY-1vo-85@gated-at.bofh.it> <p7AbE-2ii-13@gated-at.bofh.it> <p9GZk-5HW-25@gated-at.bofh.it> <p9JaO-yO-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Mar 30, 2015 at 4:49 PM, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Mon, Mar 30, 2015 at 02:23:47PM +0200, Gerd Hoffmann wrote:
>> > > Signed-off-by: Dave Airlie <airlied@redhat.com>
>> > > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>> >
>> > Standard request from my side for new drm drivers (especially if they're
>> > this simple): Can you please update the drivers to latest drm internal
>> > interfaces, i.e. using universal planes and atomic?
>>
>> Up'n'running.  Incremental patch:
>>
>> https://www.kraxel.org/cgit/linux/commit/?h=virtio-gpu-2d&id=b8edf4f38a1ec5a50f6ac8948521a12f862d3d5a
>>
>> v2 coming, but I'll go over the other reviews first.
>
> Looking good. Wrt pageflip the current MO is to handroll it in your
> driver, common approach is to use the msm async commit implementation
> msm_atomic_commit. The issue is simply that right now there's still no
> useable generic vblank callback support (drm_irq.c is a mess) hence why
> the core helpers don't support async flips yet.

I guess I didn't do a good job at looking at your v2: Cursor is still
using legacy interfaces and not a proper plane. Would be awesome if
you could fix that up. Atomic drivers really shouldn't use the legacy
cursor interfaces any more at all.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] Add virtio gpu driver. Daniel Vetter <daniel@ffwll.ch> - 2016-05-25 18:50 +0200
  Re: [PATCH] Add virtio gpu driver. Emil Velikov <emil.l.velikov@gmail.com> - 2016-05-25 18:50 +0200
  Re: [PATCH] Add virtio gpu driver. Gerd Hoffmann <kraxel@redhat.com> - 2016-05-27 09:50 +0200
    Re: [PATCH] Add virtio gpu driver. Daniel Vetter <daniel@ffwll.ch> - 2016-05-27 11:10 +0200
      Re: [PATCH] Add virtio gpu driver. Gerd Hoffmann <kraxel@redhat.com> - 2016-05-30 16:00 +0200
        Re: [PATCH] Add virtio gpu driver. Daniel Vetter <daniel@ffwll.ch> - 2016-05-30 16:50 +0200
          Re: [PATCH] Add virtio gpu driver. Gerd Hoffmann <kraxel@redhat.com> - 2016-05-31 08:30 +0200
            Re: [PATCH] Add virtio gpu driver. Daniel Vetter <daniel@ffwll.ch> - 2016-05-31 09:00 +0200
            Re: [PATCH] Add virtio gpu driver. Pekka Paalanen <ppaalanen@gmail.com> - 2016-05-31 09:10 +0200

csiph-web