Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1409909
| From | "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC PATCH 2/4] mm: Change the interface for __tlb_remove_page |
| Date | 2016-05-31 09:00 +0200 |
| Message-ID | <rELOG-7tj-9@gated-at.bofh.it> (permalink) |
| References | <rEqqS-1yz-13@gated-at.bofh.it> <rEqqS-1yz-11@gated-at.bofh.it> <rExsl-63s-7@gated-at.bofh.it> <rEJ0t-5zg-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hillf Danton <hillf.zj@alibaba-inc.com> writes:
>> >> @@ -1202,7 +1205,12 @@ again:
>> >> if (force_flush) {
>> >> force_flush = 0;
>> >> tlb_flush_mmu_free(tlb);
>> >> -
>> >> + if (pending_page) {
>> >> + /* remove the page with new size */
>> >> + __tlb_adjust_range(tlb, tlb->addr);
>> >
>> > Would you please specify why tlb->addr is used here?
>> >
>>
>> That is needed because tlb_flush_mmu_tlbonly() does a __tlb_reset_range().
>>
> If ->addr is updated in resetting, then it is a noop here to deliver tlb->addr to
> __tlb_adjust_range().
> On the other hand, if ->addr is not updated in resetting, then it is also a noop here.
>
> Do you want to update ->addr here?
>
I don't get that question. We wanted to track the alst adjusted addr in
tlb->addr because when we do a tlb_flush_mmu_tlbonly() we does a
__tlb_reset_range(), which clears tlb->start and tlb->end. Now we need
to update the range again with the last adjusted addr before we can call
__tlb_remove_page(). Look for VM_BUG_ON(!tlb->end); in
__tlb_remove_page().
-aneesh
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [RFC PATCH 2/4] mm: Change the interface for __tlb_remove_page "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2016-05-30 10:10 +0200
Re: [RFC PATCH 2/4] mm: Change the interface for __tlb_remove_page "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> - 2016-05-30 17:40 +0200
Re: [RFC PATCH 2/4] mm: Change the interface for __tlb_remove_page "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2016-05-31 06:00 +0200
Re: [RFC PATCH 2/4] mm: Change the interface for __tlb_remove_page "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> - 2016-05-31 09:00 +0200
Re: [RFC PATCH 2/4] mm: Change the interface for __tlb_remove_page "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2016-05-31 09:40 +0200
csiph-web