Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1408554

Re: [PATCH v3 07/10] <linux/hash.h>: Add support for architecture-specific functions

Show all headers | View raw

Hi George,

I see this has been applied in the mean time, but improvements
never hurt...

On Sat, May 28, 2016 at 9:57 PM, George Spelvin
<linux@sciencehorizons.net> wrote:
> --- /dev/null
> +++ b/lib/test_hash.c
> @@ -0,0 +1,250 @@

> +/*
> + * Test the various integer hash functions.  h64 (or its low-order bits)
> + * is the integer to hash.  hash_or accumulates the OR of the hash values,
> + * which are later checked to see that they cover all the requested bits.
> + *
> + * Because these functions (as opposed to the string hashes) are all
> + * inline, the code being tested is actually in the module, and you can
> + * recompile and re-test the module without rebooting.
> + */
> +static bool __init
> +test_int_hash(unsigned long long h64, u32 hash_or[2][33])
> +{
> +       int k;
> +       u32 h0 = (u32)h64, h1, h2;
> +
> +       /* Test __hash32 */
> +       hash_or[0][0] |= h1 = __hash_32(h0);
> +#ifdef HAVE_ARCH__HASH_32
> +       hash_or[1][0] |= h2 = __hash_32_generic(h0);

__hash_32_generic() always exist, right?
So you can reduce #ifdefery and increase compile coverage by dropping the
#ifdef ...

> +#if HAVE_ARCH__HASH_32 == 1
> +       if (h1 != h2) {

... and replacing this test by

        if (identical_hashes && (h1 != h2))

with identical_hashes a static const bool initialized depending on
HAVE_ARCH__HASH_32.

> +               pr_err("__hash_32(%#x) = %#x != __hash_32_generic() = %#x",
> +                       h0, h1, h2);
> +               return false;
> +       }
> +#endif
> +#endif

The same comment applies to the other hunks.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/10] String hash improvements "George Spelvin" <linux@sciencehorizons.net> - 2016-05-25 09:30 +0200
  Re: [PATCH 00/10] String hash improvements Geert Uytterhoeven <geert@linux-m68k.org> - 2016-05-25 10:10 +0200
    Re: [PATCH 00/10] String hash improvements "George Spelvin" <linux@sciencehorizons.net> - 2016-05-25 10:20 +0200
      Re: [PATCH 00/10] String hash improvements Geert Uytterhoeven <geert@linux-m68k.org> - 2016-05-25 11:00 +0200
        Re: [PATCH 00/10] String hash improvements "George Spelvin" <linux@sciencehorizons.net> - 2016-05-25 11:10 +0200
  Re: [PATCH 00/10] String hash improvements Linus Torvalds <torvalds@linux-foundation.org> - 2016-05-25 18:10 +0200
    [PATCH v3 01/10] Pull out string hash to <linux/stringhash.h> George Spelvin <linux@sciencehorizons.net> - 2016-05-28 22:00 +0200
    [PATCH v3 04/10] Change hash_64() return value to 32 bits George Spelvin <linux@sciencehorizons.net> - 2016-05-28 22:00 +0200
    [PATCH v3 03/10] <linux/sunrpc/svcauth.h>: Define hash_str() in terms of hashlen_string() George Spelvin <linux@sciencehorizons.net> - 2016-05-28 22:00 +0200
    [PATCH v3 10/10] h8300: Add <asm/hash.h> George Spelvin <linux@sciencehorizons.net> - 2016-05-28 22:00 +0200
    [PATCH v3 07/10] <linux/hash.h>: Add support for architecture-specific functions George Spelvin <linux@sciencehorizons.net> - 2016-05-28 22:00 +0200
      Re: [PATCH v3 07/10] <linux/hash.h>: Add support for  architecture-specific functions Geert Uytterhoeven <geert@linux-m68k.org> - 2016-05-29 10:00 +0200
    [PATCH v3 00/10] String hash improvements George Spelvin <linux@sciencehorizons.net> - 2016-05-28 22:00 +0200
      [PATCH v3 05/10] Eliminate bad hash multipliers from hash_32() and  hash_64() George Spelvin <linux@sciencehorizons.net> - 2016-05-28 22:00 +0200
      [PATCH v3 09/10] microblaze: Add <asm/hash.h> George Spelvin <linux@sciencehorizons.net> - 2016-05-28 22:00 +0200
      [PATCH v3 08/10] m68k: Add <asm/hash.h> George Spelvin <linux@sciencehorizons.net> - 2016-05-28 22:00 +0200
      [PATCH v3 06/10] fs/namei.c: Improve dcache hash function George Spelvin <linux@sciencehorizons.net> - 2016-05-28 22:00 +0200
        Re: [PATCH v3 06/10] fs/namei.c: Improve dcache hash function Peter Zijlstra <peterz@infradead.org> - 2016-05-30 17:20 +0200
          Re: [PATCH v3 06/10] fs/namei.c: Improve dcache hash function "George Spelvin" <linux@sciencehorizons.net> - 2016-05-30 18:10 +0200
            Re: [PATCH v3 06/10] fs/namei.c: Improve dcache hash function Peter Zijlstra <peterz@infradead.org> - 2016-05-30 18:30 +0200
              Re: [PATCH v3 06/10] fs/namei.c: Improve dcache hash function "George Spelvin" <linux@sciencehorizons.net> - 2016-05-30 20:20 +0200
      [PATCH v3 02/10] fs/namei.c: Add hashlen_string() function George Spelvin <linux@sciencehorizons.net> - 2016-05-28 22:10 +0200
      Re: [PATCH v3 00/10] String hash improvements Linus Torvalds <torvalds@linux-foundation.org> - 2016-05-28 22:50 +0200
        Re: [PATCH v3 00/10] String hash improvements "George Spelvin" <linux@sciencehorizons.net> - 2016-05-28 23:00 +0200
  [PATCH v2 00/10] String hash improvements "George Spelvin" <linux@horizon.com> - 2016-05-27 17:00 +0200

csiph-web