Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1406756

Re: [PATCH 00/10] String hash improvements

Show all headers | View raw

On Wed, May 25, 2016 at 10:11 AM, George Spelvin
<linux@sciencehorizons.net> wrote:
> Geert Uytterhoeven wrote:
>> Usually this is handled through include/asm-generic/.
>> Put the generic default implementation in include/asm-generic/hash.h.
>>
>> Architectures that need to override provide their own version, e.g.
>> arch/m68k/include/asm/hash.h. They may #include <asm-generic/hash.h>
>> if they still want to reuse parts of the generic implementation.
>>
>> Other architectures add "generic-y += hash.h" to their
>> arch/<ARCH>/include/asm/Kbuild.
>
> I thought about that, but then I'd have to edit *every* architecture,
> and might need acks from all the maintainers.
>
> I was looking for something that was a total no-op on most architectures.
>
> But if this is preferred, it's not technically difficult at all.

As you only include <asm/archhash.h> if CONFIG_HAVE_ARCH_HASH
is defined, you can also just call the arch-specific one <asm/hash.h>.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/10] String hash improvements "George Spelvin" <linux@sciencehorizons.net> - 2016-05-25 09:30 +0200
  Re: [PATCH 00/10] String hash improvements Geert Uytterhoeven <geert@linux-m68k.org> - 2016-05-25 10:10 +0200
    Re: [PATCH 00/10] String hash improvements "George Spelvin" <linux@sciencehorizons.net> - 2016-05-25 10:20 +0200
      Re: [PATCH 00/10] String hash improvements Geert Uytterhoeven <geert@linux-m68k.org> - 2016-05-25 11:00 +0200
        Re: [PATCH 00/10] String hash improvements "George Spelvin" <linux@sciencehorizons.net> - 2016-05-25 11:10 +0200
  Re: [PATCH 00/10] String hash improvements Linus Torvalds <torvalds@linux-foundation.org> - 2016-05-25 18:10 +0200
    [PATCH v3 01/10] Pull out string hash to <linux/stringhash.h> George Spelvin <linux@sciencehorizons.net> - 2016-05-28 22:00 +0200
    [PATCH v3 04/10] Change hash_64() return value to 32 bits George Spelvin <linux@sciencehorizons.net> - 2016-05-28 22:00 +0200
    [PATCH v3 03/10] <linux/sunrpc/svcauth.h>: Define hash_str() in terms of hashlen_string() George Spelvin <linux@sciencehorizons.net> - 2016-05-28 22:00 +0200
    [PATCH v3 10/10] h8300: Add <asm/hash.h> George Spelvin <linux@sciencehorizons.net> - 2016-05-28 22:00 +0200
    [PATCH v3 07/10] <linux/hash.h>: Add support for architecture-specific functions George Spelvin <linux@sciencehorizons.net> - 2016-05-28 22:00 +0200
      Re: [PATCH v3 07/10] <linux/hash.h>: Add support for  architecture-specific functions Geert Uytterhoeven <geert@linux-m68k.org> - 2016-05-29 10:00 +0200
    [PATCH v3 00/10] String hash improvements George Spelvin <linux@sciencehorizons.net> - 2016-05-28 22:00 +0200
      [PATCH v3 05/10] Eliminate bad hash multipliers from hash_32() and  hash_64() George Spelvin <linux@sciencehorizons.net> - 2016-05-28 22:00 +0200
      [PATCH v3 09/10] microblaze: Add <asm/hash.h> George Spelvin <linux@sciencehorizons.net> - 2016-05-28 22:00 +0200
      [PATCH v3 08/10] m68k: Add <asm/hash.h> George Spelvin <linux@sciencehorizons.net> - 2016-05-28 22:00 +0200
      [PATCH v3 06/10] fs/namei.c: Improve dcache hash function George Spelvin <linux@sciencehorizons.net> - 2016-05-28 22:00 +0200
        Re: [PATCH v3 06/10] fs/namei.c: Improve dcache hash function Peter Zijlstra <peterz@infradead.org> - 2016-05-30 17:20 +0200
          Re: [PATCH v3 06/10] fs/namei.c: Improve dcache hash function "George Spelvin" <linux@sciencehorizons.net> - 2016-05-30 18:10 +0200
            Re: [PATCH v3 06/10] fs/namei.c: Improve dcache hash function Peter Zijlstra <peterz@infradead.org> - 2016-05-30 18:30 +0200
              Re: [PATCH v3 06/10] fs/namei.c: Improve dcache hash function "George Spelvin" <linux@sciencehorizons.net> - 2016-05-30 20:20 +0200
      [PATCH v3 02/10] fs/namei.c: Add hashlen_string() function George Spelvin <linux@sciencehorizons.net> - 2016-05-28 22:10 +0200
      Re: [PATCH v3 00/10] String hash improvements Linus Torvalds <torvalds@linux-foundation.org> - 2016-05-28 22:50 +0200
        Re: [PATCH v3 00/10] String hash improvements "George Spelvin" <linux@sciencehorizons.net> - 2016-05-28 23:00 +0200
  [PATCH v2 00/10] String hash improvements "George Spelvin" <linux@horizon.com> - 2016-05-27 17:00 +0200

csiph-web