Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1406210

[PATCH 1/4] bcache: bch_writeback_thread() is not freezable

Show all headers | View raw

From: Jiri Kosina <jkosina@suse.cz>

bch_writeback_thread() is calling try_to_freeze(), but that's just an 
expensive no-op given the fact that the thread is not marked freezable.

I/O helper kthreads, exactly such as the bcache writeback thread, actually 
shouldn't be freezable, because they are potentially necessary for 
finalizing the image write-out.

Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---

This is a resend of a series sent more than a month ago and pinged 
multiple time since then.

 drivers/md/bcache/writeback.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/md/bcache/writeback.c b/drivers/md/bcache/writeback.c
index b9346cd..6012367 100644
--- a/drivers/md/bcache/writeback.c
+++ b/drivers/md/bcache/writeback.c
@@ -12,7 +12,6 @@
 #include "writeback.h"
 
 #include <linux/delay.h>
-#include <linux/freezer.h>
 #include <linux/kthread.h>
 #include <trace/events/bcache.h>
 
@@ -228,7 +227,6 @@ static void read_dirty(struct cached_dev *dc)
 	 */
 
 	while (!kthread_should_stop()) {
-		try_to_freeze();
 
 		w = bch_keybuf_next(&dc->writeback_keys);
 		if (!w)
@@ -433,7 +431,6 @@ static int bch_writeback_thread(void *arg)
 			if (kthread_should_stop())
 				return 0;
 
-			try_to_freeze();
 			schedule();
 			continue;
 		}
-- 
Jiri Kosina
SUSE Labs

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/4] bcache: bch_writeback_thread() is not freezable Jiri Kosina <jikos@kernel.org> - 2016-05-24 16:40 +0200
  [PATCH 4/4] MAINTAINERS: mark bcache as orphan Jiri Kosina <jikos@kernel.org> - 2016-05-24 16:40 +0200
    Re: [PATCH 4/4] MAINTAINERS: mark bcache as orphan Joe Perches <joe@perches.com> - 2016-05-24 16:50 +0200
      Re: [PATCH 4/4] MAINTAINERS: mark bcache as orphan Jiri Kosina <jikos@kernel.org> - 2016-05-25 07:10 +0200
        Re: [PATCH 4/4] MAINTAINERS: mark bcache as orphan Jens Axboe <axboe@kernel.dk> - 2016-05-25 19:40 +0200
  [PATCH 2/4] bcache: bch_allocator_thread() is not freezable Jiri Kosina <jikos@kernel.org> - 2016-05-24 16:40 +0200
  Re: [PATCH 1/4] bcache: bch_writeback_thread() is not freezable Jens Axboe <axboe@kernel.dk> - 2016-05-24 17:10 +0200

csiph-web