Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1406209

[PATCH 3/4] bcache: bch_gc_thread() is not freezable

From Jiri Kosina <jikos@kernel.org>
Newsgroups linux.kernel
Subject [PATCH 3/4] bcache: bch_gc_thread() is not freezable
Date 2016-05-24 16:40 +0200
Message-ID <rClEZ-4qa-1@gated-at.bofh.it> (permalink)
References <rClEZ-4qa-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Jiri Kosina <jkosina@suse.cz>

bch_gc_thread() doesn't mark itself freezable, so calling try_to_freeze() 
in its context is just an expensive no-op.

Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---
 drivers/md/bcache/btree.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c
index 22b9e34..eab505e 100644
--- a/drivers/md/bcache/btree.c
+++ b/drivers/md/bcache/btree.c
@@ -27,7 +27,6 @@
 
 #include <linux/slab.h>
 #include <linux/bitops.h>
-#include <linux/freezer.h>
 #include <linux/hash.h>
 #include <linux/kthread.h>
 #include <linux/prefetch.h>
@@ -1787,7 +1786,6 @@ again:
 
 		mutex_unlock(&c->bucket_lock);
 
-		try_to_freeze();
 		schedule();
 	}
 
-- 
Jiri Kosina
SUSE Labs

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH 3/4] bcache: bch_gc_thread() is not freezable Jiri Kosina <jikos@kernel.org> - 2016-05-24 16:40 +0200

csiph-web