Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1406210 > unrolled thread

[PATCH 1/4] bcache: bch_writeback_thread() is not freezable

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/4] bcache: bch_writeback_thread() is not freezable Jiri Kosina <jikos@kernel.org> - 2016-05-24 16:40 +0200
    [PATCH 4/4] MAINTAINERS: mark bcache as orphan Jiri Kosina <jikos@kernel.org> - 2016-05-24 16:40 +0200
      Re: [PATCH 4/4] MAINTAINERS: mark bcache as orphan Joe Perches <joe@perches.com> - 2016-05-24 16:50 +0200
        Re: [PATCH 4/4] MAINTAINERS: mark bcache as orphan Jiri Kosina <jikos@kernel.org> - 2016-05-25 07:10 +0200
          Re: [PATCH 4/4] MAINTAINERS: mark bcache as orphan Jens Axboe <axboe@kernel.dk> - 2016-05-25 19:40 +0200
    [PATCH 2/4] bcache: bch_allocator_thread() is not freezable Jiri Kosina <jikos@kernel.org> - 2016-05-24 16:40 +0200
    Re: [PATCH 1/4] bcache: bch_writeback_thread() is not freezable Jens Axboe <axboe@kernel.dk> - 2016-05-24 17:10 +0200

#1406210 — [PATCH 1/4] bcache: bch_writeback_thread() is not freezable

From: Jiri Kosina <jkosina@suse.cz>

bch_writeback_thread() is calling try_to_freeze(), but that's just an 
expensive no-op given the fact that the thread is not marked freezable.

I/O helper kthreads, exactly such as the bcache writeback thread, actually 
shouldn't be freezable, because they are potentially necessary for 
finalizing the image write-out.

Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---

This is a resend of a series sent more than a month ago and pinged 
multiple time since then.

 drivers/md/bcache/writeback.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/md/bcache/writeback.c b/drivers/md/bcache/writeback.c
index b9346cd..6012367 100644
--- a/drivers/md/bcache/writeback.c
+++ b/drivers/md/bcache/writeback.c
@@ -12,7 +12,6 @@
 #include "writeback.h"
 
 #include <linux/delay.h>
-#include <linux/freezer.h>
 #include <linux/kthread.h>
 #include <trace/events/bcache.h>
 
@@ -228,7 +227,6 @@ static void read_dirty(struct cached_dev *dc)
 	 */
 
 	while (!kthread_should_stop()) {
-		try_to_freeze();
 
 		w = bch_keybuf_next(&dc->writeback_keys);
 		if (!w)
@@ -433,7 +431,6 @@ static int bch_writeback_thread(void *arg)
 			if (kthread_should_stop())
 				return 0;
 
-			try_to_freeze();
 			schedule();
 			continue;
 		}
-- 
Jiri Kosina
SUSE Labs

[toc] | [next] | [standalone]

#1406215 — [PATCH 4/4] MAINTAINERS: mark bcache as orphan

The submitted patches are not being reacted upon, and Jens is only picking 
up stable fixes on an rather ad-hoc basis.

Link: lkml.kernel.org/r/574462C5.40307@kernel.dk
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 5f83015..c9906d6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2288,7 +2288,7 @@ BCACHE (BLOCK LAYER CACHE)
 M:	Kent Overstreet <kent.overstreet@gmail.com>
 L:	linux-bcache@vger.kernel.org
 W:	http://bcache.evilpiepirate.org
-S:	Maintained
+S:	Orphan
 F:	drivers/md/bcache/
 
 BDISP ST MEDIA DRIVER

-- 
Jiri Kosina
SUSE Labs

[toc] | [prev] | [next] | [standalone]

#1406228 — Re: [PATCH 4/4] MAINTAINERS: mark bcache as orphan

On Tue, 2016-05-24 at 16:38 +0200, Jiri Kosina wrote:

> The submitted patches are not being reacted upon, and Jens is only picking 
> up stable fixes on an rather ad-hoc basis.
> 
> Link: lkml.kernel.org/r/574462C5.40307@kernel.dk
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> ---
>  MAINTAINERS | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 5f83015..c9906d6 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2288,7 +2288,7 @@ BCACHE (BLOCK LAYER CACHE)
>  M:     Kent Overstreet <kent.overstreet@gmail.com>
>  L:     linux-bcache@vger.kernel.org
>  W:     http://bcache.evilpiepirate.org
> -S:     Maintained
> +S:     Orphan
>  F:     drivers/md/bcache/

Sections marked as Orphan generally
don't also have a named maintainer.

Should Kent still be listed here?

[toc] | [prev] | [next] | [standalone]

#1406630 — Re: [PATCH 4/4] MAINTAINERS: mark bcache as orphan

On Tue, 24 May 2016, Joe Perches wrote:

> > The submitted patches are not being reacted upon, and Jens is only picking 
> > up stable fixes on an rather ad-hoc basis.
> > 
> > Link: lkml.kernel.org/r/574462C5.40307@kernel.dk
> > Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> > ---
> >  MAINTAINERS | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 5f83015..c9906d6 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -2288,7 +2288,7 @@ BCACHE (BLOCK LAYER CACHE)
> >  M:     Kent Overstreet <kent.overstreet@gmail.com>
> >  L:     linux-bcache@vger.kernel.org
> >  W:     http://bcache.evilpiepirate.org
> > -S:     Maintained
> > +S:     Orphan
> >  F:     drivers/md/bcache/
> 
> Sections marked as Orphan generally
> don't also have a named maintainer.
> 
> Should Kent still be listed here?

Thanks for the remark. I'd leave this up to Jens, as apparently at the end 
of the day he's the one relaying stability bugfixes upstream; so it might 
actually make sense to have him listed there eventually (while keeping the 
Orphan status).

-- 
Jiri Kosina
SUSE Labs

[toc] | [prev] | [next] | [standalone]

#1407107 — Re: [PATCH 4/4] MAINTAINERS: mark bcache as orphan

On 05/24/2016 11:07 PM, Jiri Kosina wrote:
> On Tue, 24 May 2016, Joe Perches wrote:
>
>>> The submitted patches are not being reacted upon, and Jens is only picking
>>> up stable fixes on an rather ad-hoc basis.
>>>
>>> Link: lkml.kernel.org/r/574462C5.40307@kernel.dk
>>> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
>>> ---
>>>   MAINTAINERS | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index 5f83015..c9906d6 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -2288,7 +2288,7 @@ BCACHE (BLOCK LAYER CACHE)
>>>   M:     Kent Overstreet <kent.overstreet@gmail.com>
>>>   L:     linux-bcache@vger.kernel.org
>>>   W:     http://bcache.evilpiepirate.org
>>> -S:     Maintained
>>> +S:     Orphan
>>>   F:     drivers/md/bcache/
>>
>> Sections marked as Orphan generally
>> don't also have a named maintainer.
>>
>> Should Kent still be listed here?
>
> Thanks for the remark. I'd leave this up to Jens, as apparently at the end
> of the day he's the one relaying stability bugfixes upstream; so it might
> actually make sense to have him listed there eventually (while keeping the
> Orphan status).

Let's leave the entry. Kent is still around, it's just not actively 
being maintained.

-- 
Jens Axboe

[toc] | [prev] | [next] | [standalone]

#1406216 — [PATCH 2/4] bcache: bch_allocator_thread() is not freezable

From: Jiri Kosina <jkosina@suse.cz>

bch_allocator_thread() is calling try_to_freeze(), but that's just an 
expensive no-op given the fact that the thread is not marked freezable.

Bucket allocator has to be up and running to the very last stages of the 
suspend, as the bcache I/O that's in flight (think of writing an 
hibernation image to a swap device served by bcache).

Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---
 drivers/md/bcache/alloc.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/md/bcache/alloc.c b/drivers/md/bcache/alloc.c
index 8eeab72..ca4abe1 100644
--- a/drivers/md/bcache/alloc.c
+++ b/drivers/md/bcache/alloc.c
@@ -64,7 +64,6 @@
 #include "btree.h"
 
 #include <linux/blkdev.h>
-#include <linux/freezer.h>
 #include <linux/kthread.h>
 #include <linux/random.h>
 #include <trace/events/bcache.h>
@@ -288,7 +287,6 @@ do {									\
 		if (kthread_should_stop())				\
 			return 0;					\
 									\
-		try_to_freeze();					\
 		schedule();						\
 		mutex_lock(&(ca)->set->bucket_lock);			\
 	}								\

-- 
Jiri Kosina
SUSE Labs

[toc] | [prev] | [next] | [standalone]

#1406234

On 05/24/2016 08:38 AM, Jiri Kosina wrote:
> From: Jiri Kosina <jkosina@suse.cz>
>
> bch_writeback_thread() is calling try_to_freeze(), but that's just an
> expensive no-op given the fact that the thread is not marked freezable.
>
> I/O helper kthreads, exactly such as the bcache writeback thread, actually
> shouldn't be freezable, because they are potentially necessary for
> finalizing the image write-out.

Applied 1-4, thanks Jiri.

-- 
Jens Axboe

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web