Re: [Patch v5 5/8] firmware: qcom: scm: Convert to streaming DMA APIS

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Andy Gross <andy.gross@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [Patch v5 5/8] firmware: qcom: scm: Convert to streaming DMA APIS
Date	Wed, 25 May 2016 23:20:01 +0200
Message-ID	<rCOnD-5Tr-1@gated-at.bofh.it> (permalink)
References	<rycgW-37N-3@gated-at.bofh.it> <rycgW-37N-1@gated-at.bofh.it> <rC3I6-1vP-15@gated-at.bofh.it> <rC5gR-2zt-7@gated-at.bofh.it> <rCxPP-4ey-3@gated-at.bofh.it> <rCO4i-5ww-13@gated-at.bofh.it>
X-Original-To	Kevin Hilman <khilman@baylibre.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=VlXEtxaLatVUCHKSoVFnktGu9PMJdwfAo3zHdyC1jqs=; b=bI9nsnO/Xi0u1Iiuy+7HoVjqMEQXKTj4SlOJYfoCHRtMyQPTm2g16vS0nOsh+3vYEr Z4ve5aSbMvs51K5Ba1gjcWTDoNHUxs+Zlh/2C6+obyh8wVoVhPw/v74D0duQN4Lk5UYv 01wiFfCei4N1+UpHSmUyeFPXSlLeSe10CbtiU=
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=VlXEtxaLatVUCHKSoVFnktGu9PMJdwfAo3zHdyC1jqs=; b=mpDZJAueu8EsBv6XM0kORcxd30TkwF2B7rKEAAjYHIHanEcck7rImQTTktObhHo43c +KX4vFx1pAwn1qSI3DD9tfV9tSYIYTBoAuTuixDrzcj7qBiaKVJOcX6seSZd+zQjPO9J ARoX257PumG6BAFiFIEeCRC2kDLHz02yxtFkFrq/ul9Cd47ULavasptnrN8VJDpZmkJ+ XuucP54UgOVhomtr0whsPa49+a210B7qhIsyrliyzT5A5PFYnyuPLwbW40ivSiIyoOjS oXbjwrAqYMUKpa7Cxxy2lFEhU0yIgwD2dbCGh4oBReXwWHMNWcgmjrGkz9u3YjWPFAHs DT7A==
X-Gm-Message-State	ALyK8tJGSS4NbmiKUlugZTVUdkk0keSyp8f+0Dll8RiEmhMg4xF9iR5h4BfivtHp8O/UJaL0oz896LfKNyaP8RLT
MIME-Version	1.0
X-Received	by 10.37.42.134 with SMTP id q128mr2404573ybq.6.1464210930006; Wed, 25 May 2016 14:15:30 -0700 (PDT)
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	47
Organization	linux.* mail to news gateway
X-Original-Cc	linux-arm-msm <linux-arm-msm@vger.kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, lkml <linux-kernel@vger.kernel.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, Stephen Boyd <sboyd@codeaurora.org>, devicetree <devicetree@vger.kernel.org>, jilai wang <jilaiw@codeaurora.org>
X-Original-Date	Wed, 25 May 2016 16:15:29 -0500
X-Original-Message-ID	<CAPBZ5QdAYR2puF6SmfKi0khQ4BfcdTiW_j0_T43Gh03bZSf64Q@mail.gmail.com>
X-Original-References	<1463111221-6963-1-git-send-email-andy.gross@linaro.org> <1463111221-6963-6-git-send-email-andy.gross@linaro.org> <CAOi56cVB1Z-gO6Dx0KOSr9wiRF3Y9ahDHe0=qT9WW4MdFMhjng@mail.gmail.com> <CAPBZ5Qc0oZ+k_5OiUGU6c9jFfcmAfsK3Uy-s=ONGCSGzCDyYNw@mail.gmail.com> <20160525033731.GA30220@hector.attlocal.net> <7hbn3tg8ul.fsf@baylibre.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1407217

Show key headers only | View raw

On 25 May 2016 at 15:50, Kevin Hilman <khilman@baylibre.com> wrote:
> Andy Gross <andy.gross@linaro.org> writes:
>
>> On Mon, May 23, 2016 at 04:02:06PM -0500, Andy Gross wrote:
>>> On 23 May 2016 at 14:26, Kevin Hilman <khilman@kernel.org> wrote:
>>> > Hi Andy,
>>> >
>>> > On Thu, May 12, 2016 at 8:46 PM, Andy Gross <andy.gross@linaro.org> wrote:
>>> >> This patch converts the Qualcomm SCM driver to use the streaming DMA APIs
>>> >> for communication buffers.
>>> >>
>>> >> Signed-off-by: Andy Gross <andy.gross@linaro.org>
>>> >
>>> > This patch has landed in linux-next in the form of commit a551c3dbd689
>>> > (firmware: qcom: scm: Convert to streaming DMA APIS), and kernelci.org
>>> > found some boot breakage in next-20160523 on apq8064[1] which was
>>> > bisected down to this commit.
>>> >
>>> > I reverted this commit on top of next-20160523 and it no longer
>>> > builds, so I didn't validate if things boot again with this patch
>>> > reverted.
>>>
>>> Ouch I missed this failure.  I'll investigate and get it fixed.
>>
>> So the root cause was the fact that the DFAB clock required by the SCM is an RPM
>> clock.  That support isn't present yet in the kernel, so SCM probe fails.
>>
>> The core clock is really only accessed so that we can bump the clock on it up to
>> the max for performance.  As such, I'll make it optional in the platform code.
>>
>> This does bring up the issue of probe defer causing issues with the spm driver,
>> as it calls set_warm_boot_addr.  That may have to be addressed, but is probably
>> a problem best fixed in the spm.
>
> Nice, thanks for the explanation.
>
> Is there a patch somewhere you'd like me to test? or were you able to
> dust off an 8064 platform for testing?

I had the ifc6410, but it took me a while to find the darn 5V supply.
The docs lie when they say 5V-12V.  In any case, I threw a patch on
top of next to fix this.  I need to amend my set of patches to include
these changes and add the DT information for the 8064.

Regards,

Andy

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[Patch v5 5/8] firmware: qcom: scm: Convert to streaming DMA APIS Andy Gross <andy.gross@linaro.org> - 2016-05-13 05:50 +0200
  Re: [Patch v5 5/8] firmware: qcom: scm: Convert to streaming DMA APIS Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-05-14 01:50 +0200
    Re: [Patch v5 5/8] firmware: qcom: scm: Convert to streaming DMA APIS Andy Gross <andy.gross@linaro.org> - 2016-05-16 07:10 +0200
  Re: [Patch v5 5/8] firmware: qcom: scm: Convert to streaming DMA APIS Kevin Hilman <khilman@kernel.org> - 2016-05-23 21:30 +0200
    Re: [Patch v5 5/8] firmware: qcom: scm: Convert to streaming DMA APIS Andy Gross <andy.gross@linaro.org> - 2016-05-23 23:10 +0200
      Re: [Patch v5 5/8] firmware: qcom: scm: Convert to streaming DMA APIS Andy Gross <andy.gross@linaro.org> - 2016-05-25 05:40 +0200
        Re: [Patch v5 5/8] firmware: qcom: scm: Convert to streaming DMA APIS Kevin Hilman <khilman@baylibre.com> - 2016-05-25 23:00 +0200
          Re: [Patch v5 5/8] firmware: qcom: scm: Convert to streaming DMA APIS Andy Gross <andy.gross@linaro.org> - 2016-05-25 23:20 +0200

csiph-web