Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1407216
| From | Arend van Spriel <arend.vanspriel@broadcom.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V2] brcmfmac: print error if p2p_ifadd firmware command fails |
| Date | 2016-05-25 23:10 +0200 |
| Message-ID | <rCOdZ-5Pr-65@gated-at.bofh.it> (permalink) |
| References | <rCrKp-99-3@gated-at.bofh.it> <rCrKp-99-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 24-05-16 23:05, Rafał Miłecki wrote:
> This is helpful for debugging, without this all I was getting from "iw"
> command on device with BCM43602 was:
>> command failed: Too many open files in system (-23)
>
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> ---
> V2: s/in/if/ in commit message
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
> index 1652a48..f7b7e29 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
> @@ -2031,7 +2031,7 @@ static int brcmf_p2p_request_p2p_if(struct brcmf_p2p_info *p2p,
> err = brcmf_fil_iovar_data_set(ifp, "p2p_ifadd", &if_request,
> sizeof(if_request));
> if (err)
> - return err;
> + brcmf_err("p2p_ifadd failed %d\n", err);
I would prefer adding a more generic failure message including ifname
and type in brcmf_cfg80211_add_iface() in cfg80211.c.
Regards,
Arend
>
> return err;
> }
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] brcmfmac: print error in p2p_ifadd firmware command fails Rafał Miłecki <zajec5@gmail.com> - 2016-05-24 23:10 +0200
[PATCH V2] brcmfmac: print error if p2p_ifadd firmware command fails Rafał Miłecki <zajec5@gmail.com> - 2016-05-24 23:10 +0200
Re: [PATCH V2] brcmfmac: print error if p2p_ifadd firmware command fails Arend van Spriel <arend.vanspriel@broadcom.com> - 2016-05-25 23:10 +0200
[PATCH V3] brcmfmac: print error if p2p_ifadd firmware command fails Rafał Miłecki <zajec5@gmail.com> - 2016-05-26 01:00 +0200
Re: [PATCH V3] brcmfmac: print error if p2p_ifadd firmware command fails Arend Van Spriel <arend.vanspriel@broadcom.com> - 2016-05-26 10:10 +0200
[PATCH V4] brcmfmac: print errors if creating interface fails Rafał Miłecki <zajec5@gmail.com> - 2016-05-27 01:10 +0200
csiph-web