Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1401313
| From | Andy Gross <andy.gross@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [Patch v5 5/8] firmware: qcom: scm: Convert to streaming DMA APIS |
| Date | 2016-05-16 07:10 +0200 |
| Message-ID | <rziWZ-2Hq-3@gated-at.bofh.it> (permalink) |
| References | <rycgW-37N-3@gated-at.bofh.it> <rycgW-37N-1@gated-at.bofh.it> <ryv0e-5hN-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, May 13, 2016 at 04:48:52PM -0700, Bjorn Andersson wrote: > > + cmd->len = cpu_to_le32(alloc_len); > > + cmd->buf_offset = cpu_to_le32(sizeof(*cmd)); > > + cmd->resp_hdr_offset = cpu_to_le32(sizeof(*cmd) + cmd_len); > > + > > cmd->id = cpu_to_le32((svc_id << 10) | cmd_id); > > if (cmd_buf) > > - memcpy(qcom_scm_get_command_buffer(cmd), cmd_buf, cmd_len); > > + memcpy(cmd->buf, cmd_buf, cmd_len); > > + > > + rsp = (void *)cmd->buf + le32_to_cpu(cmd->resp_hdr_offset); > > I believe resp_hdr_offset counts from the beginning of the buffer and > that this therefor is supposed to be: > > rsp = (void *)cmd + le32_to_cpu(cmd->resp_hdr_offset); > > With that corrected, feel free to add: > > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> I'll fix that up. Thanks for the review. Andy
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[Patch v5 5/8] firmware: qcom: scm: Convert to streaming DMA APIS Andy Gross <andy.gross@linaro.org> - 2016-05-13 05:50 +0200
Re: [Patch v5 5/8] firmware: qcom: scm: Convert to streaming DMA APIS Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-05-14 01:50 +0200
Re: [Patch v5 5/8] firmware: qcom: scm: Convert to streaming DMA APIS Andy Gross <andy.gross@linaro.org> - 2016-05-16 07:10 +0200
Re: [Patch v5 5/8] firmware: qcom: scm: Convert to streaming DMA APIS Kevin Hilman <khilman@kernel.org> - 2016-05-23 21:30 +0200
Re: [Patch v5 5/8] firmware: qcom: scm: Convert to streaming DMA APIS Andy Gross <andy.gross@linaro.org> - 2016-05-23 23:10 +0200
Re: [Patch v5 5/8] firmware: qcom: scm: Convert to streaming DMA APIS Andy Gross <andy.gross@linaro.org> - 2016-05-25 05:40 +0200
Re: [Patch v5 5/8] firmware: qcom: scm: Convert to streaming DMA APIS Kevin Hilman <khilman@baylibre.com> - 2016-05-25 23:00 +0200
Re: [Patch v5 5/8] firmware: qcom: scm: Convert to streaming DMA APIS Andy Gross <andy.gross@linaro.org> - 2016-05-25 23:20 +0200
csiph-web