Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1348921

Re: [PATCH v2] thermal: Fix build error of missing devm_ioremap_resource on UM

Show all headers | View raw

Hi Krzysztof,

On Thu, Mar 3, 2016 at 9:44 AM, Krzysztof Kozlowski
<k.kozlowski@samsung.com> wrote:
> --- a/drivers/thermal/Kconfig
> +++ b/drivers/thermal/Kconfig
> @@ -177,7 +177,7 @@ config THERMAL_EMULATION
>
>  config HISI_THERMAL
>         tristate "Hisilicon thermal driver"
> -       depends on (ARCH_HISI && CPU_THERMAL && OF) || COMPILE_TEST
> +       depends on (ARCH_HISI && CPU_THERMAL && OF) || COMPILE_TEST && HAS_IOMEM

I think these are easier to read and maintain if you split hard and soft
dependencies, e.g.

        depends on HAS_IOMEM
        depends on (ARCH_HISI && CPU_THERMAL && OF) || COMPILE_TEST

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] thermal: Fix build error of missing devm_ioremap_resource  on UM Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-03 09:50 +0100
  Re: [PATCH v2] thermal: Fix build error of missing  devm_ioremap_resource on UM Geert Uytterhoeven <geert@linux-m68k.org> - 2016-03-03 10:10 +0100
    Re: [PATCH v2] thermal: Fix build error of missing  devm_ioremap_resource on UM Geert Uytterhoeven <geert@linux-m68k.org> - 2016-03-03 13:00 +0100
    Re: [PATCH v2] thermal: Fix build error of missing  devm_ioremap_resource on UM Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-03 13:00 +0100

csiph-web