Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1349050
| From | Geert Uytterhoeven <geert@linux-m68k.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] thermal: Fix build error of missing devm_ioremap_resource on UM |
| Date | 2016-03-03 13:00 +0100 |
| Message-ID | <r8A5c-6Bm-7@gated-at.bofh.it> (permalink) |
| References | <r8x7k-4p8-17@gated-at.bofh.it> <r8xqG-4L2-19@gated-at.bofh.it> <r8A5c-6Bm-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Krzysztof,
On Thu, Mar 3, 2016 at 12:49 PM, Krzysztof Kozlowski
<k.kozlowski@samsung.com> wrote:
> 2016-03-03 18:01 GMT+09:00 Geert Uytterhoeven <geert@linux-m68k.org>:
>> On Thu, Mar 3, 2016 at 9:44 AM, Krzysztof Kozlowski
>> <k.kozlowski@samsung.com> wrote:
>> > --- a/drivers/thermal/Kconfig
>> > +++ b/drivers/thermal/Kconfig
>> > @@ -177,7 +177,7 @@ config THERMAL_EMULATION
>> >
>> > config HISI_THERMAL
>> > tristate "Hisilicon thermal driver"
>> > - depends on (ARCH_HISI && CPU_THERMAL && OF) || COMPILE_TEST
>> > + depends on (ARCH_HISI && CPU_THERMAL && OF) || COMPILE_TEST && HAS_IOMEM
>>
>> I think these are easier to read and maintain if you split hard and soft
>> dependencies, e.g.
>>
>> depends on HAS_IOMEM
>> depends on (ARCH_HISI && CPU_THERMAL && OF) || COMPILE_TEST
>
> Indeed this looks more readable but the HAS_IOMEM becomes a missing
> dependency only for COMPILE_TEST. Usually it is included in the
> architecture.
HAS_IOMEM is still a dependency, but it's implied by ARCH_HISI.
COMPILE_TEST allows to discover more dependencies, and document them.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2] thermal: Fix build error of missing devm_ioremap_resource on UM Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-03 09:50 +0100
Re: [PATCH v2] thermal: Fix build error of missing devm_ioremap_resource on UM Geert Uytterhoeven <geert@linux-m68k.org> - 2016-03-03 10:10 +0100
Re: [PATCH v2] thermal: Fix build error of missing devm_ioremap_resource on UM Geert Uytterhoeven <geert@linux-m68k.org> - 2016-03-03 13:00 +0100
Re: [PATCH v2] thermal: Fix build error of missing devm_ioremap_resource on UM Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-03 13:00 +0100
csiph-web