Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1349068

Re: [PATCH v2] thermal: Fix build error of missing devm_ioremap_resource on UM

Show all headers | View raw

2016-03-03 18:01 GMT+09:00 Geert Uytterhoeven <geert@linux-m68k.org>:
>
> Hi Krzysztof,
>
> On Thu, Mar 3, 2016 at 9:44 AM, Krzysztof Kozlowski
> <k.kozlowski@samsung.com> wrote:
> > --- a/drivers/thermal/Kconfig
> > +++ b/drivers/thermal/Kconfig
> > @@ -177,7 +177,7 @@ config THERMAL_EMULATION
> >
> >  config HISI_THERMAL
> >         tristate "Hisilicon thermal driver"
> > -       depends on (ARCH_HISI && CPU_THERMAL && OF) || COMPILE_TEST
> > +       depends on (ARCH_HISI && CPU_THERMAL && OF) || COMPILE_TEST && HAS_IOMEM
>
> I think these are easier to read and maintain if you split hard and soft
> dependencies, e.g.
>
>         depends on HAS_IOMEM
>         depends on (ARCH_HISI && CPU_THERMAL && OF) || COMPILE_TEST

Indeed this looks more readable but the HAS_IOMEM becomes a missing
dependency only for COMPILE_TEST. Usually it is included in the
architecture.

None of the approaches look perfect to me...

Thanks for feedback!
Best regards,
Krzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] thermal: Fix build error of missing devm_ioremap_resource  on UM Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-03 09:50 +0100
  Re: [PATCH v2] thermal: Fix build error of missing  devm_ioremap_resource on UM Geert Uytterhoeven <geert@linux-m68k.org> - 2016-03-03 10:10 +0100
    Re: [PATCH v2] thermal: Fix build error of missing  devm_ioremap_resource on UM Geert Uytterhoeven <geert@linux-m68k.org> - 2016-03-03 13:00 +0100
    Re: [PATCH v2] thermal: Fix build error of missing  devm_ioremap_resource on UM Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-03 13:00 +0100

csiph-web