[PATCH 4/6] pwm: pwm-lpc18xx-sct: test clock rate to avoid division by 0

From	Wolfram Sang <wsa@the-dreams.de>
Newsgroups	linux.kernel
Subject	[PATCH 4/6] pwm: pwm-lpc18xx-sct: test clock rate to avoid division by 0
Date	2016-03-02 23:40 +0100
Message-ID	<r8nB0-682-9@gated-at.bofh.it> (permalink)
References	<r8nAZ-682-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Wolfram Sang <wsa+renesas@sang-engineering.com>

The clk API may return 0 on clk_get_rate, so we should check the result before
using it as a divisor.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---

Should go individually via subsystem tree.

 drivers/pwm/pwm-lpc18xx-sct.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/pwm/pwm-lpc18xx-sct.c b/drivers/pwm/pwm-lpc18xx-sct.c
index 9163085101bc94..6487962c355c03 100644
--- a/drivers/pwm/pwm-lpc18xx-sct.c
+++ b/drivers/pwm/pwm-lpc18xx-sct.c
@@ -360,6 +360,8 @@ static int lpc18xx_pwm_probe(struct platform_device *pdev)
 	}
 
 	lpc18xx_pwm->clk_rate = clk_get_rate(lpc18xx_pwm->pwm_clk);
+	if (!lpc18xx_pwm->clk_rate)
+		return -EINVAL;
 
 	mutex_init(&lpc18xx_pwm->res_lock);
 	mutex_init(&lpc18xx_pwm->period_lock);
-- 
2.7.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 4/6] pwm: pwm-lpc18xx-sct: test clock rate to avoid division by 0 Wolfram Sang <wsa@the-dreams.de> - 2016-03-02 23:40 +0100
  Re: [PATCH 4/6] pwm: pwm-lpc18xx-sct: test clock rate to avoid  division by 0 Joachim Eastwood <manabian@gmail.com> - 2016-03-02 23:50 +0100
    Re: [PATCH 4/6] pwm: pwm-lpc18xx-sct: test clock rate to avoid  division by 0 Wolfram Sang <wsa@the-dreams.de> - 2016-03-03 00:00 +0100

csiph-web