Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1348575
| From | Wolfram Sang <wsa@the-dreams.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 1/6] ide: palm_bk3710: test clock rate to avoid division by 0 |
| Date | 2016-03-02 23:40 +0100 |
| Message-ID | <r8nB0-682-11@gated-at.bofh.it> (permalink) |
| References | <r8nAZ-682-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Wolfram Sang <wsa+renesas@sang-engineering.com> The clk API may return 0 on clk_get_rate, so we should check the result before using it as a divisor. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- Should go individually via subsystem tree. drivers/ide/palm_bk3710.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/ide/palm_bk3710.c b/drivers/ide/palm_bk3710.c index 8012e43bf8f618..46427ea01753b4 100644 --- a/drivers/ide/palm_bk3710.c +++ b/drivers/ide/palm_bk3710.c @@ -325,6 +325,8 @@ static int __init palm_bk3710_probe(struct platform_device *pdev) clk_enable(clk); rate = clk_get_rate(clk); + if (!rate) + return -EINVAL; /* NOTE: round *down* to meet minimum timings; we count in clocks */ ideclk_period = 1000000000UL / rate; -- 2.7.0
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH 1/6] ide: palm_bk3710: test clock rate to avoid division by 0 Wolfram Sang <wsa@the-dreams.de> - 2016-03-02 23:40 +0100
csiph-web