Re: [PATCH 2/3] x86/mce/AMD, EDAC: Simplify SMCA decoding

From	Borislav Petkov <bp@alien8.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/3] x86/mce/AMD, EDAC: Simplify SMCA decoding
Date	2016-03-02 17:30 +0100
Message-ID	<r8hOW-1I2-11@gated-at.bofh.it> (permalink)
References	<r7Ekx-tv-7@gated-at.bofh.it> <r7Eky-tv-17@gated-at.bofh.it> <r8cFA-6tO-9@gated-at.bofh.it> <r8cFA-6tO-7@gated-at.bofh.it> <r8hOW-1I2-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Mar 02, 2016 at 09:52:23AM -0600, Aravind Gopalakrishnan wrote:
> So, I think we should continue this approach and have something like this-
> static const char * const amd_core_mcablock_names[] = {
>         [SMCA_LS]         = "load_store",
>         [SMCA_IF]         = "insn_fetch",
>         [SMCA_L2_CACHE]   = "l2_cache",
>         [SMCA_DE]         = "decode_unit",
>         [RES]                   = "",
>         [SMCA_EX]         = "execution_unit",
>         [SMCA_FP]         = "floating_point",
>         [SMCA_L3_CACHE]   = "l3_cache",
> };
> 
> static const char * const amd_df_mcablock_names[] = {
>         [SMCA_CS]  = "coherent_slave",
>         [SMCA_PIE] = "pie",
> };
> 
> (Split arrays again because I feel it'd be better to have arrays ordered
> according to mca_type values)

Ok, care to take the patch and redo it as you suggest?

I really don't want to be assigning strings each time during decoding.

Also, make sure the strings are as human readable as possible and so
that users can at least have an idea what we're saying. "load_store"
is better than "LS", "insn_fetch" is better than "IF", etc. Some
abbreviations should remain, though. "platform_security_processor" is
yucky and I guess there we can stick to "PSP". Ditto for "SMU"...

Making the unabbreviated lowercase for sysfs usage is fine too, of
course.

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

Thread

[PATCH V2 0/5] Updates to EDAC and AMD MCE driver Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com> - 2016-02-29 23:20 +0100
  [PATCH V2 3/5] x86/mce/AMD: Fix logic to obtain block address Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com> - 2016-02-29 23:20 +0100
  [PATCH V2 1/5] x86/mce: Move MCx_CONFIG MSR definition Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com> - 2016-02-29 23:20 +0100
  [PATCH V2 2/5] EDAC, MCE, AMD: Enable error decoding of Scalable MCA errors Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com> - 2016-02-29 23:20 +0100
    [PATCH 2/3] x86/mce/AMD, EDAC: Simplify SMCA decoding Borislav Petkov <bp@alien8.de> - 2016-03-02 12:00 +0100
      Re: [PATCH 2/3] x86/mce/AMD, EDAC: Simplify SMCA decoding Borislav Petkov <bp@alien8.de> - 2016-03-02 17:30 +0100
        Re: [PATCH 2/3] x86/mce/AMD, EDAC: Simplify SMCA decoding Borislav Petkov <bp@alien8.de> - 2016-03-02 17:40 +0100
    Re: [PATCH V2 2/5] EDAC, MCE, AMD: Enable error decoding of Scalable  MCA errors Borislav Petkov <bp@alien8.de> - 2016-03-02 12:00 +0100
      [PATCH 3/3] EDAC, mce_amd: Correct error paths Borislav Petkov <bp@alien8.de> - 2016-03-02 12:00 +0100
      [PATCH 1/3] x86/mce/AMD, EDAC: Enable error decoding of Scalable MCA  errors Borislav Petkov <bp@alien8.de> - 2016-03-02 12:00 +0100

csiph-web