Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1348301

RE: [PATCH 0/2] staging: comedi: comedi.h: Avoid BIT macro

Show all headers | View raw

On Wednesday, March 02, 2016 7:28 AM, Ian Abbott wrote:
> Patch 1 effectively reverts commit 72315cdaba9d on linux-next "Staging:
> comedi: Prefer using the BIT macro"), but I replaced the use of the BIT
> macro with hexadecimal constants instead of the original left bit-shift
> expressions.  We shouldn't use the BIT macro in "comedi.h" as it is
> intended to be included in the UAPI headers.
>
> Patch 2 just fixes the kernel-doc comment for struct comedi_krange.
>
> 1) staging: comedi: comedi.h: Do not use BIT macro
> 2) staging: comedi: comedi.h: Fix comment for struct comedi_krange
>
>  drivers/staging/comedi/comedi.h | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

Thanks for fixing this. I noticed the same issue yesterday.

Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] staging: comedi: comedi.h: Avoid BIT macro Ian Abbott <abbotti@mev.co.uk> - 2016-03-02 15:30 +0100
  [PATCH 2/2] staging: comedi: comedi.h: Fix comment for struct comedi_krange Ian Abbott <abbotti@mev.co.uk> - 2016-03-02 15:30 +0100
  RE: [PATCH 0/2] staging: comedi: comedi.h: Avoid BIT macro Hartley Sweeten <HartleyS@visionengravers.com> - 2016-03-02 17:30 +0100

csiph-web