Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1349660

Re: [PATCH v2 3/4] resource: Add device-managed insert/remove_resource()

Show all headers | View raw

On Wed, Mar 2, 2016 at 2:50 PM, Toshi Kani <toshi.kani@hpe.com> wrote:
> insert_resource() and remove_resouce() are called by producers
> of resources, such as FW modules and bus drivers.  These modules
> may be implemented as loadable modules.
>
> Add device-managed implementaions of insert_resource() and
> remove_resouce() functions.
>
> Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Borislav Petkov <bp@suse.de>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Dan Williams <dan.j.williams@intel.com>
> ---
>  include/linux/ioport.h |    5 +++
>  kernel/resource.c      |   69 ++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 74 insertions(+)
>
> diff --git a/include/linux/ioport.h b/include/linux/ioport.h
> index 8017b8b..3580038 100644
> --- a/include/linux/ioport.h
> +++ b/include/linux/ioport.h
> @@ -259,6 +259,11 @@ extern struct resource * __devm_request_region(struct device *dev,
>
>  extern void __devm_release_region(struct device *dev, struct resource *parent,
>                                   resource_size_t start, resource_size_t n);
> +
> +extern int devm_insert_resource(struct device *dev, struct resource *root,
> +                                struct resource *new);
> +extern void devm_remove_resource(struct device *dev, struct resource *old);
> +
>  extern int iomem_map_sanity_check(resource_size_t addr, unsigned long size);
>  extern int iomem_is_exclusive(u64 addr);
>
> diff --git a/kernel/resource.c b/kernel/resource.c
> index effb6ee..b1a3394 100644
> --- a/kernel/resource.c
> +++ b/kernel/resource.c
> @@ -1449,6 +1449,75 @@ void __devm_release_region(struct device *dev, struct resource *parent,
>  EXPORT_SYMBOL(__devm_release_region);
>
>  /*
> + * Remove function for devm_insert_resource() and devm_remove_resource().
> + */
> +static void devm_resource_remove(struct device *dev, void *ptr)
> +{
> +       struct resource **r = ptr;
> +
> +       remove_resource(*r);
> +}
> +

Maybe call this __devm_remove_resource?  I think this makes it clearer
that it is a private helper function.  I was initially confused about
the difference between devm_resource_remove and devm_remove_resource.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/4] Support persistent memory as reserved type in e820/EFI Toshi Kani <toshi.kani@hpe.com> - 2016-03-02 23:00 +0100
  [PATCH v2 4/4] ACPI: Change NFIT driver to insert new resource Toshi Kani <toshi.kani@hpe.com> - 2016-03-02 23:00 +0100
    Re: [PATCH v2 4/4] ACPI: Change NFIT driver to insert new resource Dan Williams <dan.j.williams@intel.com> - 2016-03-03 23:50 +0100
      Re: [PATCH v2 4/4] ACPI: Change NFIT driver to insert new resource Toshi Kani <toshi.kani@hpe.com> - 2016-03-04 00:20 +0100
  [PATCH v2 3/4] resource: Add device-managed insert/remove_resource() Toshi Kani <toshi.kani@hpe.com> - 2016-03-02 23:00 +0100
    Re: [PATCH v2 3/4] resource: Add device-managed insert/remove_resource() Dan Williams <dan.j.williams@intel.com> - 2016-03-03 23:50 +0100
      Re: [PATCH v2 3/4] resource: Add device-managed  insert/remove_resource() Toshi Kani <toshi.kani@hpe.com> - 2016-03-04 00:00 +0100
  [PATCH v2 1/4] resource: Change __request_region to inherit from immediate parent Toshi Kani <toshi.kani@hpe.com> - 2016-03-02 23:00 +0100
  [PATCH v2 2/4] resource: Add remove_resource interface Toshi Kani <toshi.kani@hpe.com> - 2016-03-02 23:00 +0100

csiph-web