Re: [PATCH 3/3] ARM: omap1/ams-delta: warn about failed regulator enable

Path	csiph.com!news.freedyn.net!aioe.org!bofh.it!news.nic.it!robomod
From	Aaro Koskinen <aaro.koskinen@iki.fi>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] ARM: omap1/ams-delta: warn about failed regulator enable
Date	Wed, 24 Feb 2016 00:50:01 +0100
Message-ID	<r5uSl-4mi-7@gated-at.bofh.it> (permalink)
References	<r5lFo-6dV-25@gated-at.bofh.it> <r5lFo-6dV-35@gated-at.bofh.it>
X-Original-To	Arnd Bergmann <arnd@arndb.de>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.24 (2015-08-30)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	21
Organization	linux.* mail to news gateway
X-Original-Cc	Tony Lindgren <tony@atomide.com>, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Wed, 24 Feb 2016 01:40:44 +0200
X-Original-Message-ID	<20160223234044.GW1640@darkstar.musicnaut.iki.fi>
X-Original-References	<1456235876-4088840-1-git-send-email-arnd@arndb.de> <1456235876-4088840-4-git-send-email-arnd@arndb.de>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1341184

Show key headers only | View raw

On Tue, Feb 23, 2016 at 02:57:53PM +0100, Arnd Bergmann wrote:
> The modem pm handler in the ams-delta board uses regulator_enable()
> but does not check for a successful return code:
> 
> board-ams-delta.c:521:3: error: ignoring return value of 'regulator_enable', declared with attribute warn_unused_result [-Werror=unused-result]
> 
> It is not easy to propagate that return code to the callers in
> uart_configure_port/uart_suspend_port/uart_resume_port, unless
> we change all UART drivers, and it is unclear what those would
> do with the return code.
> 
> Instead, this patch uses a runtime warning to replace the
> compiletime warning. I have checked that the regulator in question
> is hardcoded to a fixed-voltage GPIO regulator, and that should
> never fail to get enabled if I understand the code right.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Aaro Koskinen <aaro.koskinen@iki.fi>

A.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] ARM: omap1/ams-delta: warn about failed regulator enable Arnd Bergmann <arnd@arndb.de> - 2016-02-23 15:00 +0100
  Re: [PATCH 3/3] ARM: omap1/ams-delta: warn about failed regulator  enable One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2016-02-23 17:20 +0100
  Re: [PATCH 3/3] ARM: omap1/ams-delta: warn about failed regulator  enable Tony Lindgren <tony@atomide.com> - 2016-02-23 17:20 +0100
  Re: [PATCH 3/3] ARM: omap1/ams-delta: warn about failed regulator  enable Aaro Koskinen <aaro.koskinen@iki.fi> - 2016-02-24 00:50 +0100

csiph-web