Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1341184

Re: [PATCH 3/3] ARM: omap1/ams-delta: warn about failed regulator enable

Show all headers | View raw

On Tue, Feb 23, 2016 at 02:57:53PM +0100, Arnd Bergmann wrote:
> The modem pm handler in the ams-delta board uses regulator_enable()
> but does not check for a successful return code:
> 
> board-ams-delta.c:521:3: error: ignoring return value of 'regulator_enable', declared with attribute warn_unused_result [-Werror=unused-result]
> 
> It is not easy to propagate that return code to the callers in
> uart_configure_port/uart_suspend_port/uart_resume_port, unless
> we change all UART drivers, and it is unclear what those would
> do with the return code.
> 
> Instead, this patch uses a runtime warning to replace the
> compiletime warning. I have checked that the regulator in question
> is hardcoded to a fixed-voltage GPIO regulator, and that should
> never fail to get enabled if I understand the code right.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Aaro Koskinen <aaro.koskinen@iki.fi>

A.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] ARM: omap1/ams-delta: warn about failed regulator enable Arnd Bergmann <arnd@arndb.de> - 2016-02-23 15:00 +0100
  Re: [PATCH 3/3] ARM: omap1/ams-delta: warn about failed regulator  enable One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2016-02-23 17:20 +0100
  Re: [PATCH 3/3] ARM: omap1/ams-delta: warn about failed regulator  enable Tony Lindgren <tony@atomide.com> - 2016-02-23 17:20 +0100
  Re: [PATCH 3/3] ARM: omap1/ams-delta: warn about failed regulator  enable Aaro Koskinen <aaro.koskinen@iki.fi> - 2016-02-24 00:50 +0100

csiph-web