Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1340823

Re: [PATCH 3/3] ARM: omap1/ams-delta: warn about failed regulator enable

Show all headers | View raw

> > It is not easy to propagate that return code to the callers in
> > uart_configure_port/uart_suspend_port/uart_resume_port, unless
> > we change all UART drivers, and it is unclear what those would
> > do with the return code.
> > 
> > Instead, this patch uses a runtime warning to replace the
> > compiletime warning. I have checked that the regulator in question
> > is hardcoded to a fixed-voltage GPIO regulator, and that should
> > never fail to get enabled if I understand the code right.  
> 
> Looks OK to me:

If it was a concern for a real driver I think I'd perform a hangup on the
port at that moment. That's what happens if for example you hot unplug a
serial port which would be approximately the same as finding out you
can't power it back up.

Alan

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] ARM: omap1/ams-delta: warn about failed regulator enable Arnd Bergmann <arnd@arndb.de> - 2016-02-23 15:00 +0100
  Re: [PATCH 3/3] ARM: omap1/ams-delta: warn about failed regulator  enable One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2016-02-23 17:20 +0100
  Re: [PATCH 3/3] ARM: omap1/ams-delta: warn about failed regulator  enable Tony Lindgren <tony@atomide.com> - 2016-02-23 17:20 +0100
  Re: [PATCH 3/3] ARM: omap1/ams-delta: warn about failed regulator  enable Aaro Koskinen <aaro.koskinen@iki.fi> - 2016-02-24 00:50 +0100

csiph-web